refactor(stepper, stepper-item): getElementProp is refactored out in favor of inheritable props set directly on parent
#7593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… refactored out across child components as an outdated pattern in favor of inheritable props set directly on parent
…oss child components as an outdated pattern in favor of inheritable props set directly on parent
Elijbet
added
the
refactor
Elijbet
changed the title
getElementProp is refactored out across child components as an outdated pattern in favor of inheritable props set directly on parent
Elijbet
changed the title
getElementProp is refactored out across child components as an outdated pattern in favor of inheritable props set directly on parentgetElementProp is refactored out in favor of inheritable props set directly on parent
**Related Issue:** #7574 ## Summary - use dragAndDrop util for more tests.
**Related Issue:** None ## Summary - catch error when beforeBack promise is rejected
**Related Issue:** #6381 ## Summary - catch error when beforeClose promise is rejected
**Related Issue:** #4738 ## Summary Adds `single-persist` mode to `calcite-combobox` to allow users to opt-in to this change in selection behavior (vs making it a breaking change on the current `single` selection mode). `clearDisabled` will behave the same way unless we want to make an exception to this mode.
Elijbet
force-pushed
the
elijbet/6038-refactor-getElementProp-stepper-item
branch
from
274a60e
to
501693b
Compare
driskull
reviewed
Aug 30, 2023
Elijbet
added
pr ready for visual snapshots
jcfranco
approved these changes
Aug 31, 2023
packages/calcite-components/src/components/tree-item/tree-item.tsx
Outdated
Show resolved
Hide resolved
Elijbet
added
pr ready for visual snapshots
jcfranco
added
pr ready for visual snapshots
jcfranco
added
pr ready for visual snapshots
jcfranco
added
pr ready for visual snapshots
benelan
added a commit
that referenced
this pull request
Sep 1, 2023
* origin/main: (35 commits) ci: make sure to exit on maitenance milestone failure (#7656) chore: release next fix(block): provide textual name on collapse and expansion to AT (#7652) chore: release main (#7571) chore: release next fix(block, block-section): improve a11y (#7557) chore: release next fix: add drag styles for improved UX (#7644) fix(input, input-number): correctly sanitize numbers when pasting string with 'e' (#7648) chore: release next feat(flow): add support for custom flow-item elements (#7608) chore: release next fix(list, sortable-list, value-list): Emit calciteListOrderChange when dragging between lists (#7614) feat(input-number): add integer property (#7646) chore: release next fix(accordion, accordion-item): improve a11y (#7560) refactor(stepper, stepper-item): `getElementProp` is refactored out in favor of inheritable props set directly on parent (#7593) docs(contributing): update the commit message format example URL (#7641) chore: release next feat(input-date-picker): normalize year to current century for user typed values only (#7638) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6038
Summary
getElementPropis refactored out across child components as an outdated pattern in favor of inheritable props set directly on the parent.Instead of the
stepper-itemlooking up the parent foricon, layout, numbered, and scale, these get set by thestepperparent.The logic for setting these props thus moves to the parent, getting rid of the
getElementPropaltogether. The parent component gets amutationObserverto do this as well as watchers for when it needs to modify the children.Inherited props addressed: