feat: calcite-design-tokens in monorepo package #7621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 348f22d. # Conflicts: # tokens/component/stepper-item.json
chore: updating my branch with the latest from main
alisonailea
added
pr ready for visual snapshots
alisonailea
added
the
p - high
also include links
…calcite-components into astump/7180-design-tokens-in-monorepo
alisonailea
added
pr ready for visual snapshots
alisonailea
force-pushed
the
astump/merge-calcite-design-tokens
branch
from
e43ed45
to
457b5eb
Compare
alisonailea
added
pr ready for visual snapshots
…calcite-components into astump/7180-design-tokens-in-monorepo
…calcite-components into astump/7180-design-tokens-in-monorepo
alisonailea
added
pr ready for visual snapshots
benelan
reviewed
Oct 2, 2023
| "patch:ssr": "ts-node support/patchSSR.ts", | ||
| "tsc": "tsc" |
There was a problem hiding this comment.
Can you undo this change? I'm not sure why Stencil created an npm script for tsc in their example, but I'd like to do some tests before removing it, since it's not related to this PR.
Let's keep unrelated changes in separate PRs, especially when they are for different packages in the monorepo
alisonailea
removed
p - high
jcfranco
requested changes
Oct 2, 2023
There was a problem hiding this comment.
There's quite a bit of changes unrelated to the monorepo move that I think need to be split up into separate PRs (e.g., wiring up of additional tokens, modifying the React wrapper build, package script order, renamed tokens, addition of global). IMO, the extent of those changes are risky to add for today's release.
@alisonailea @benelan Let's sync up first thing tomorrow about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180 #7325
Summary
This pulls the Calcite-Design-Token repo (with commit history) into the Calcite-Design-System Monorepo.