Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): Allow wrapping text in table-header and table-cell #7665

Merged
merged 3 commits into from
Sep 2, 2023

Conversation

macandcheese
Copy link
Contributor

Summary

Adds styles to allow long text in header or table cell to wrap. Adds story.

@macandcheese macandcheese requested a review from a team as a code owner September 2, 2023 01:26
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Sep 2, 2023
@macandcheese macandcheese added this to the 1.7.1 Maintenance Release milestone Sep 2, 2023
@macandcheese macandcheese added low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Sep 2, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏓

@macandcheese macandcheese merged commit 15cb2bf into main Sep 2, 2023
10 checks passed
@macandcheese macandcheese deleted the macandcheese/fix-table-wrapping branch September 2, 2023 15:39
jcfranco pushed a commit that referenced this pull request Sep 7, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 1.8.0</summary>

##
[1.8.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.7.0...@esri/calcite-components@1.8.0)
(2023-09-06)


### Features

* **flow:** Split up custom flow item interfaces
([#7666](#7666))
([6c22e7c](6c22e7c))


### Bug Fixes

* **action-group:** Honor flex-grow on slotted actions
([#7690](#7690))
([0777234](0777234))
* **block:** Provide textual name on collapse and expansion to AT
([#7652](#7652))
([85bd71b](85bd71b))
* **input-date-picker:** Apply default numbering system to avoid browser
inferring from locale
([#7682](#7682))
([3e1ed2d](3e1ed2d))
* **input-time-zone:** Prevent items from being deselected
([#7661](#7661))
([c2dd436](c2dd436))
* **list-item:** Do not call preventDefault on enter key within slotted
actions
([#7684](#7684))
([c3261f0](c3261f0))
* **list:** Remove unnecessary z-index
([#7678](#7678))
([1f4cd97](1f4cd97))
* **modal:** CalciteModalClose should emit on close button click
([#7680](#7680))
([796bf90](796bf90))
* **sheet:** CalciteSheetClose should emit on scrim click
([#7685](#7685))
([6ae963e](6ae963e))
* **sheet:** Update shadow style in display-mode="float"
([#7664](#7664))
([851bedb](851bedb))
* **table:** Allow wrapping text in table-header and table-cell
([#7665](#7665))
([15cb2bf](15cb2bf))
* **time-picker:** Focus corresponding input when nudge buttons are
clicked
([#7650](#7650))
([9c7d846](9c7d846))
</details>

<details><summary>@esri/calcite-components-react: 1.8.0</summary>

##
[1.8.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.7.0...@esri/calcite-components-react@1.8.0)
(2023-09-06)


### Bug Fixes

* Resolve vite errors due to using expressions in dynamic imports
([#7671](#7671))
([b4c1038](b4c1038))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^1.8.0-next.2 to ^1.8.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants