Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use utility to ensure test-specific data attributes are removed in prod builds #8171

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

refactor: use utility to ensure test-specific data attributes are removed in prod builds #8171

wants to merge 2 commits into from
+43 −10

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 14, 2023 •
edited
Loading

Related Issue: #6760

Summary

This new util should help remove test-specific data attributes in the dist build and in tree-shaken builds using the components output build.

We could also enable an ESLint rule to flag data-test-x attributes and recommend using this pattern instead.

Questions

  1. Should we recommend spreading the test attribute object at the end or in place of where the data attribute would reside?
  2. Would it be helpful to rename the util to include data attribute or something along those lines? Open to suggestions here since I'm not keen on the current name.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Nov 14, 2023
@jcfranco jcfranco mentioned this pull request Nov 14, 2023
Open
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 22, 2023
@jcfranco jcfranco mentioned this pull request Jan 9, 2024
Merged
@benelan benelan changed the base branch from main to dev June 10, 2024 09:16
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jun 13, 2024
@jcfranco jcfranco mentioned this pull request Jun 17, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcfranco jcfranco

Labels
refactor Issues tied to code that needs to be significantly reworked. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jcfranco