Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): fix navigating initially when multiple items are selected #9613

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Jun 17, 2024

Related Issue: #6776

Summary

  • When a chip is focused, the activeChipIndex is updated
  • Only allow tabindex on one chip or the input.
  • Adds tests

@driskull driskull marked this pull request as ready for review June 17, 2024 17:09
@driskull driskull requested a review from a team as a code owner June 17, 2024 17:09
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 17, 2024
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪
⚪⚫⚪⚪⚪⚫⚪⚪⚫⚫⚪⚪⚫⚫⚫⚪⚪⚫⚫⚫⚪⚫⚫⚫⚫⚪⚫⚪
⚪⚫⚫⚪⚪⚫⚪⚫⚪⚪⚫⚪⚪⚫⚪⚪⚫⚪⚪⚪⚪⚫⚪⚪⚪⚪⚫⚪
⚪⚫⚪⚫⚪⚫⚪⚫⚪⚪⚫⚪⚪⚫⚪⚪⚫⚪⚪⚪⚪⚫⚫⚫⚪⚪⚫⚪
⚪⚫⚪⚪⚫⚫⚪⚫⚪⚪⚫⚪⚪⚫⚪⚪⚫⚪⚪⚪⚪⚫⚪⚪⚪⚪⚪⚪
⚪⚫⚪⚪⚪⚫⚪⚪⚫⚫⚪⚪⚫⚫⚫⚪⚪⚫⚫⚫⚪⚫⚫⚫⚫⚪⚫⚪
⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪

@jcfranco
Copy link
Member

Sidebar: WDYT about this pattern to remove test-specific data attributes in production builds?

@driskull
Copy link
Member Author

Sidebar: WDYT about #8171 to remove test-specific data attributes in production builds?

Yeah I think that would be good. Probably a low priority since it will just decrease build size marginally.

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 17, 2024
@driskull driskull merged commit 5d9509b into dev Jun 17, 2024
12 checks passed
@driskull driskull deleted the dris0000/combobox-chips-tabindex branch June 17, 2024 18:46
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants