Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: feat(alert): make component responsive #8195

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 17, 2023

Related Issue: N/A

Summary

Rolls back responsiveness (#7755) in favor of upcoming alert stack UX (#2835).

See #7921 (comment) for more info.

Roll back alert responsiveness (#7755) in favor of upcoming alert queue UX (#2835)
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 17, 2023
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Nov 17, 2023
@jcfranco jcfranco marked this pull request as ready for review November 17, 2023 01:27
@jcfranco jcfranco requested a review from a team as a code owner November 17, 2023 01:27
@jcfranco jcfranco marked this pull request as draft November 17, 2023 01:37
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 20, 2023
@jcfranco jcfranco marked this pull request as ready for review November 21, 2023 01:01
@jcfranco jcfranco merged commit 2f4ff6c into main Nov 21, 2023
16 checks passed
@jcfranco jcfranco deleted the jcfranco/roll-back-alert-responsiveness branch November 21, 2023 17:10
@github-actions github-actions bot added this to the 2023 November Priorities milestone Nov 21, 2023
benelan added a commit that referenced this pull request Nov 23, 2023
* origin/main: (30 commits)
  test: add token snapshot tests (#8050)
  chore: release next
  fix(color-picker, popover, shell-panel, slider, tooltip): Register events on the window instead of the document (#8247)
  fix(list-item): Reserve space for empty open lists. (#8239)
  fix: dragging floating ui components (#8230)
  fix(list-item): an item with an empty slotted list should be openable. (#8240)
  fix(input): prevents mutating value on `blur` when `type="number"` (#8245)
  chore: release main (#8092)
  chore: downgrade eslint plugin after reverting breaking change (#8238)
  refactor(combobox): fix linting errors (#8235)
  chore: downgrade packages after reverting 2.0.0-next.0 change (#8237)
  chore: release next
  revert: feat(stepper-item)!: remove support for previousStep and nextStep in messages (#8222) (#8232)
  feat(stepper): enable responsive layout (#7744)
  feat(combobox): limit display of selected items with new selection-display prop (#7912)
  chore: release next
  build: update browserslist db (#8218)
  fix(list-item): fix rendering of open icon. (#8207)
  revert: feat(alert): make component responsive (#8195)
  fix(input-number): prevents mutating value on blur (#8226)
  ...
benelan added a commit that referenced this pull request Nov 23, 2023
* origin/main: (30 commits)
  test: add token snapshot tests (#8050)
  chore: release next
  fix(color-picker, popover, shell-panel, slider, tooltip): Register events on the window instead of the document (#8247)
  fix(list-item): Reserve space for empty open lists. (#8239)
  fix: dragging floating ui components (#8230)
  fix(list-item): an item with an empty slotted list should be openable. (#8240)
  fix(input): prevents mutating value on `blur` when `type="number"` (#8245)
  chore: release main (#8092)
  chore: downgrade eslint plugin after reverting breaking change (#8238)
  refactor(combobox): fix linting errors (#8235)
  chore: downgrade packages after reverting 2.0.0-next.0 change (#8237)
  chore: release next
  revert: feat(stepper-item)!: remove support for previousStep and nextStep in messages (#8222) (#8232)
  feat(stepper): enable responsive layout (#7744)
  feat(combobox): limit display of selected items with new selection-display prop (#7912)
  chore: release next
  build: update browserslist db (#8218)
  fix(list-item): fix rendering of open icon. (#8207)
  revert: feat(alert): make component responsive (#8195)
  fix(input-number): prevents mutating value on blur (#8226)
  ...
benelan pushed a commit that referenced this pull request Nov 24, 2023
**Related Issue:** N/A

Rolls back responsiveness (#7755) in favor of upcoming alert stack UX
(#2835).

See
#7921 (comment)
for more info.
benelan pushed a commit that referenced this pull request Nov 24, 2023
**Related Issue:** N/A

Rolls back responsiveness (#7755) in favor of upcoming alert stack UX
(#2835).

See
#7921 (comment)
for more info.
benelan pushed a commit that referenced this pull request Nov 26, 2023
**Related Issue:** N/A

Rolls back responsiveness (#7755) in favor of upcoming alert stack UX
(#2835).

See
#7921 (comment)
for more info.
jcfranco added a commit that referenced this pull request Nov 28, 2023
**Related Issue:** N/A

## Summary

Removes responsiveness-related declaration no longer necessary after
#8195.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants