-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: feat(alert): make component responsive #8195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Nov 17, 2023
github-actions
bot
added
the
chore
Issues with changes that don't modify src or test files.
label
Nov 17, 2023
jcfranco
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Nov 20, 2023
alisonailea
approved these changes
Nov 21, 2023
Merged
benelan
added a commit
that referenced
this pull request
Nov 23, 2023
* origin/main: (30 commits) test: add token snapshot tests (#8050) chore: release next fix(color-picker, popover, shell-panel, slider, tooltip): Register events on the window instead of the document (#8247) fix(list-item): Reserve space for empty open lists. (#8239) fix: dragging floating ui components (#8230) fix(list-item): an item with an empty slotted list should be openable. (#8240) fix(input): prevents mutating value on `blur` when `type="number"` (#8245) chore: release main (#8092) chore: downgrade eslint plugin after reverting breaking change (#8238) refactor(combobox): fix linting errors (#8235) chore: downgrade packages after reverting 2.0.0-next.0 change (#8237) chore: release next revert: feat(stepper-item)!: remove support for previousStep and nextStep in messages (#8222) (#8232) feat(stepper): enable responsive layout (#7744) feat(combobox): limit display of selected items with new selection-display prop (#7912) chore: release next build: update browserslist db (#8218) fix(list-item): fix rendering of open icon. (#8207) revert: feat(alert): make component responsive (#8195) fix(input-number): prevents mutating value on blur (#8226) ...
benelan
added a commit
that referenced
this pull request
Nov 23, 2023
* origin/main: (30 commits) test: add token snapshot tests (#8050) chore: release next fix(color-picker, popover, shell-panel, slider, tooltip): Register events on the window instead of the document (#8247) fix(list-item): Reserve space for empty open lists. (#8239) fix: dragging floating ui components (#8230) fix(list-item): an item with an empty slotted list should be openable. (#8240) fix(input): prevents mutating value on `blur` when `type="number"` (#8245) chore: release main (#8092) chore: downgrade eslint plugin after reverting breaking change (#8238) refactor(combobox): fix linting errors (#8235) chore: downgrade packages after reverting 2.0.0-next.0 change (#8237) chore: release next revert: feat(stepper-item)!: remove support for previousStep and nextStep in messages (#8222) (#8232) feat(stepper): enable responsive layout (#7744) feat(combobox): limit display of selected items with new selection-display prop (#7912) chore: release next build: update browserslist db (#8218) fix(list-item): fix rendering of open icon. (#8207) revert: feat(alert): make component responsive (#8195) fix(input-number): prevents mutating value on blur (#8226) ...
benelan
pushed a commit
that referenced
this pull request
Nov 24, 2023
**Related Issue:** N/A Rolls back responsiveness (#7755) in favor of upcoming alert stack UX (#2835). See #7921 (comment) for more info.
benelan
pushed a commit
that referenced
this pull request
Nov 24, 2023
**Related Issue:** N/A Rolls back responsiveness (#7755) in favor of upcoming alert stack UX (#2835). See #7921 (comment) for more info.
benelan
pushed a commit
that referenced
this pull request
Nov 26, 2023
**Related Issue:** N/A Rolls back responsiveness (#7755) in favor of upcoming alert stack UX (#2835). See #7921 (comment) for more info.
jcfranco
added a commit
that referenced
this pull request
Nov 28, 2023
**Related Issue:** N/A ## Summary Removes responsiveness-related declaration no longer necessary after #8195.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Issues with changes that don't modify src or test files.
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Rolls back responsiveness (#7755) in favor of upcoming alert stack UX (#2835).
See #7921 (comment) for more info.