Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(combobox): fix linting errors #8235

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

benelan
Copy link
Member

@benelan benelan commented Nov 21, 2023

Related Issue: #7912

Summary

Fixes linting errors introduced by the PR linked above.

@benelan benelan requested a review from a team as a code owner November 21, 2023 20:58
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Nov 21, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨🧹✨

@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 21, 2023
@benelan benelan merged commit 7075db1 into main Nov 21, 2023
14 checks passed
@benelan benelan deleted the benelan/fix-combobox-linting-errors branch November 21, 2023 21:38
@github-actions github-actions bot added this to the 2023 November Priorities milestone Nov 21, 2023
benelan added a commit that referenced this pull request Nov 23, 2023
* origin/main: (30 commits)
  test: add token snapshot tests (#8050)
  chore: release next
  fix(color-picker, popover, shell-panel, slider, tooltip): Register events on the window instead of the document (#8247)
  fix(list-item): Reserve space for empty open lists. (#8239)
  fix: dragging floating ui components (#8230)
  fix(list-item): an item with an empty slotted list should be openable. (#8240)
  fix(input): prevents mutating value on `blur` when `type="number"` (#8245)
  chore: release main (#8092)
  chore: downgrade eslint plugin after reverting breaking change (#8238)
  refactor(combobox): fix linting errors (#8235)
  chore: downgrade packages after reverting 2.0.0-next.0 change (#8237)
  chore: release next
  revert: feat(stepper-item)!: remove support for previousStep and nextStep in messages (#8222) (#8232)
  feat(stepper): enable responsive layout (#7744)
  feat(combobox): limit display of selected items with new selection-display prop (#7912)
  chore: release next
  build: update browserslist db (#8218)
  fix(list-item): fix rendering of open icon. (#8207)
  revert: feat(alert): make component responsive (#8195)
  fix(input-number): prevents mutating value on blur (#8226)
  ...
benelan added a commit that referenced this pull request Nov 23, 2023
* origin/main: (30 commits)
  test: add token snapshot tests (#8050)
  chore: release next
  fix(color-picker, popover, shell-panel, slider, tooltip): Register events on the window instead of the document (#8247)
  fix(list-item): Reserve space for empty open lists. (#8239)
  fix: dragging floating ui components (#8230)
  fix(list-item): an item with an empty slotted list should be openable. (#8240)
  fix(input): prevents mutating value on `blur` when `type="number"` (#8245)
  chore: release main (#8092)
  chore: downgrade eslint plugin after reverting breaking change (#8238)
  refactor(combobox): fix linting errors (#8235)
  chore: downgrade packages after reverting 2.0.0-next.0 change (#8237)
  chore: release next
  revert: feat(stepper-item)!: remove support for previousStep and nextStep in messages (#8222) (#8232)
  feat(stepper): enable responsive layout (#7744)
  feat(combobox): limit display of selected items with new selection-display prop (#7912)
  chore: release next
  build: update browserslist db (#8218)
  fix(list-item): fix rendering of open icon. (#8207)
  revert: feat(alert): make component responsive (#8195)
  fix(input-number): prevents mutating value on blur (#8226)
  ...
benelan added a commit that referenced this pull request Nov 24, 2023
**Related Issue:** #7912

## Summary

Fixes linting errors introduced by the PR linked above.
benelan added a commit that referenced this pull request Nov 24, 2023
**Related Issue:** #7912

## Summary

Fixes linting errors introduced by the PR linked above.
benelan added a commit that referenced this pull request Nov 26, 2023
**Related Issue:** #7912

## Summary

Fixes linting errors introduced by the PR linked above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants