Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storybook): drop unnecessary React logic #9103

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Apr 9, 2024

Related Issue: N/A

Summary

This is no longer be needed after recent Storybook updates (see #8944 and #9030).

✨🧹✨

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Apr 9, 2024
@jcfranco jcfranco changed the title refactor: drop unnecessary React logic from storybook refactor(storybook): drop unnecessary React logic Apr 9, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 9, 2024
@jcfranco jcfranco requested a review from a team as a code owner April 12, 2024 05:54
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 12, 2024
@jcfranco jcfranco merged commit 23aad2d into main Apr 12, 2024
16 checks passed
@jcfranco jcfranco deleted the jcfranco/drop-react-handling-from-storybook branch April 12, 2024 16:23
@github-actions github-actions bot added this to the 2024-04-30 - Apr Release milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants