chore: restore Stencil build step prior screenshot-tests:preview
#9180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
requested review from
benelan,
driskull and
geospatialem
as code owners
jcfranco
added
the
skip visual snapshots
github-actions
bot
added
the
chore
jcfranco
deleted the
jcfranco/restore-storybook-build-in-screenshot-test-preview-script
branch
benelan
added a commit
that referenced
this pull request
Apr 27, 2024
…lidation-apis * origin/main: (26 commits) chore: release next fix: fix memory leak affecting components using conditionally-rendered slots (#9208) test(segmented-control): enable form validation tests (#9206) build(deps): update storybook monorepo to v8.0.9 (#9198) build(deps): update dependency rollup to v4.16.4 (#9190) build(deps): update dependency @stencil/core to v4.17.1 (#9199) build(deps): update typescript-eslint monorepo to v7.7.1 (#9201) build(deps): update amannn/action-semantic-pull-request action to v5.5.2 (#9189) build(deps): update dependency type-fest to v4.16.0 (#9200) chore: release next feat: ensure all components inherit font-family (#8388) chore: release next fix(slider): fix fill placement and tick styling when ranged (#9204) fix(combobox): update the focused chevron icon color (#9202) docs: add convention for property values (#9185) chore: restore Stencil build step prior `screenshot-tests:preview` (#9180) chore: release next fix(tree-item): do not select when chevron clicked (#9115) chore: release next fix(slider): style ticks according to the fill placement (#9196) ...
benelan
added a commit
that referenced
this pull request
Apr 27, 2024
…ustom-event * origin/main: (24 commits) chore: release next fix: fix memory leak affecting components using conditionally-rendered slots (#9208) test(segmented-control): enable form validation tests (#9206) build(deps): update storybook monorepo to v8.0.9 (#9198) build(deps): update dependency rollup to v4.16.4 (#9190) build(deps): update dependency @stencil/core to v4.17.1 (#9199) build(deps): update typescript-eslint monorepo to v7.7.1 (#9201) build(deps): update amannn/action-semantic-pull-request action to v5.5.2 (#9189) build(deps): update dependency type-fest to v4.16.0 (#9200) chore: release next feat: ensure all components inherit font-family (#8388) chore: release next fix(slider): fix fill placement and tick styling when ranged (#9204) fix(combobox): update the focused chevron icon color (#9202) docs: add convention for property values (#9185) chore: restore Stencil build step prior `screenshot-tests:preview` (#9180) chore: release next fix(tree-item): do not select when chevron clicked (#9115) chore: release next fix(slider): style ticks according to the fill placement (#9196) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Restores build step unintentionally removed in #9030.