Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal toggle -- when toggle element has children, clicking on children doesn't open modal #953

Closed
skitterm opened this issue May 2, 2018 · 1 comment
Closed

Modal toggle -- when toggle element has children, clicking on children doesn't open modal #953

skitterm opened this issue May 2, 2018 · 1 comment
Assignees
@paulcpederson
Labels
bug in development javascript
Projects
v1.0.3

Comments

@skitterm
Copy link
Contributor

skitterm commented May 2, 2018

If a js-modal-trigger element has any child elements, clicking on those children will not open the modal as expected.

Modal with button trigger: https://jsbin.com/huzenujuji/1/edit?html,output -- The modal opens when clicking anywhere on the button

Modal whose button trigger has a span child: https://jsbin.com/huzenujuji/edit?html,output -- The modal soes not open when clicking on the button text, only works when clicking elsewhere on the button.

This is problematic for cases where you want to open a modal by clicking anywhere in a drop zone, for example.
@paulcpederson paulcpederson added this to To do in v1.0.3 Jun 16, 2018
@paulcpederson paulcpederson self-assigned this Jun 16, 2018
@paulcpederson paulcpederson moved this from To do to In progress in v1.0.3 Aug 4, 2018
paulcpederson added a commit to paulcpederson/calcite-web that referenced this issue Aug 4, 2018
@paulcpederson
Esri#953 - fix modal toggles when toggle has child element
2f184dd
macandcheese pushed a commit that referenced this issue Aug 6, 2018
@paulcpederson @macandcheese
📦 v1.0.3 (#971)
299448a 
* #966 - fix diacritics in hebrew

* #960 - allow override of vw-ratio variable

* #969 - increase contrast of green labels

* #953 - fix modal toggles when toggle has child element

* 📦 v1.0.3

* fix formatting of links in CHANGELOG
@paulcpederson
Copy link
Member

fixed in v1.0.3

@paulcpederson paulcpederson moved this from In progress to Done in v1.0.3 Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulcpederson paulcpederson

Labels
bug in development javascript
Projects
No open projects
v1.0.3
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulcpederson @skitterm