Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vw-ratio is not override-able #960

Closed
skitterm opened this issue Jun 9, 2018 · 1 comment
Closed

vw-ratio is not override-able #960

skitterm opened this issue Jun 9, 2018 · 1 comment
Assignees
@paulcpederson
Labels
bug in development
Projects
v1.0.3

Comments

@skitterm
Copy link
Contributor

skitterm commented Jun 9, 2018 •
edited
Loading

In the grid docs (http://esri.github.io/calcite-web/documentation/grid/#configuration), it says you can override $vw-ratio to change how wide the .grid-container can become. However, I noticed that $vw-ratio cannot be customized. Looks like that's due to a missing !default here.
@paulcpederson paulcpederson self-assigned this Jun 16, 2018
@paulcpederson paulcpederson added this to To do in v1.0.3 Jun 16, 2018
@paulcpederson paulcpederson moved this from To do to In progress in v1.0.3 Aug 4, 2018
paulcpederson added a commit to paulcpederson/calcite-web that referenced this issue Aug 4, 2018
@paulcpederson
Esri#960 - allow override of vw-ratio variable
fa32b2c
macandcheese pushed a commit that referenced this issue Aug 6, 2018
@paulcpederson @macandcheese
📦 v1.0.3 (#971)
299448a 
* #966 - fix diacritics in hebrew

* #960 - allow override of vw-ratio variable

* #969 - increase contrast of green labels

* #953 - fix modal toggles when toggle has child element

* 📦 v1.0.3

* fix formatting of links in CHANGELOG
@paulcpederson
Copy link
Member

overridable as per v1.0.3

@paulcpederson paulcpederson moved this from In progress to Done in v1.0.3 Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulcpederson paulcpederson

Labels
bug in development
Projects
No open projects
v1.0.3
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulcpederson @skitterm