Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing overlapping regex for #31 #32

Merged
merged 1 commit into from
Sep 2, 2017
Merged

Fixing overlapping regex for #31 #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,11 @@ module.exports = {
new RegExp(path.parse(outputPaths.testSupport.js.testSupport).name + '(.*js)')
],
patterns: [{
match: /([^A-Za-z0-9_#]|^|["])define(\W|["]|$)/g,
replacement: '$1efineday$2'
match: /([^A-Za-z0-9_#]|^|["])define(?=\W|["]|$)/g,
replacement: '$1efineday'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the $2 from the replacements?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the lookahead, there is no second grouping, and "$2" will be appended on every match.

}, {
match: /(\W|^|["])require(\W|["]|$)/g,
replacement: '$1equireray$2'
match: /(\W|^|["])require(?=\W|["]|$)/g,
replacement: '$1equireray'
}]
};
var dataTree = stringReplace(tree, data);
Expand Down