This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
DotNet: forward all headers to client response #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponse to the client response.
afili
changed the title
This was referenced Jul 15, 2014
bsvensson
added a commit
that referenced
this pull request
Jul 25, 2014
…sponse DotNet: forward all headers to client response
|
As a result of this... duplicate header values are being passed back to the client. We are operating in a 'Integrated Windows Authentication' environment and I can see both the server and persistent-auth headers are duplicated. Was this intentional and do we see any potential impacts with this scenario? I did not see any application functionality degraded, but did not look right. Thanks! |
|
@pfoppe - You're correct. The proxy needs to be smarter about header values, some should be passed through, some should not. For example |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added logic to forward all headers that are allowed from the server response to the client response.
proposed fix for #67