Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't override /back cooldown using permissions. #4747

Closed
matipoirierg opened this issue Jan 12, 2022 · 2 comments · Fixed by #4759
Closed

Can't override /back cooldown using permissions. #4747

matipoirierg opened this issue Jan 12, 2022 · 2 comments · Fixed by #4759
Labels
module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.

Comments

@matipoirierg
Copy link

matipoirierg commented Jan 12, 2022 •
edited

Type of bug

Other unexpected behaviour.

/ess dump all output

https://essentialsx.net/dump.html?id=54329dd3a0df473b8d71de8223643f4f

Error log (if applicable)

No response

Bug description

I have set a cooldown for the back command on the essentials config, but giving cooldown override permissions to a group isn't working. (Tried with: essentials.teleport.cooldown.bypass.*, essentials.teleport.cooldown.bypass.back and essentials.teleport.timer.bypass)

Steps to reproduce

1.-Set a cooldown for /back on the config.
2.-Give cooldown override permissions to a group.
3.-Try to use /back twice.

Expected behaviour

/back cooldown should be overridden on groups with cooldown override permissions.

Actual behaviour

/back have cooldown even with the override cooldown permissions.
@matipoirierg matipoirierg added the bug: unconfirmed Potential bugs that need replicating to verify. label Jan 12, 2022
@LilianLem
Copy link

Can confirm that, I've exactly the same issue. I'm using LuckPerms to manage permissions.

@JRoy JRoy mentioned this issue Jan 16, 2022
Merged
@JRoy JRoy added module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests. and removed bug: unconfirmed Potential bugs that need replicating to verify. labels Jan 16, 2022
@matipoirierg
Copy link
Author

Hi been testing this branch for months, working without any issues, could you merge to latest dev builds pls?

mdcfe added a commit that referenced this issue Feb 13, 2023
@JRoy @pop4959 @mdcfe
Add per-command command cooldown bypass permissions (#4759)
25ad8ac 
Adds the permission `essentials.commandcooldowns.bypass.<command name>` to bypass the cooldown for a specific command.

Closes #4747.

Co-authored-by: pop4959 <pop4959@gmail.com>
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add per-command command cooldown bypass permissions JRoy/Essentials-PR
3 participants
@JRoy @LilianLem @matipoirierg