Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-command command cooldown bypass permissions #4759

Merged
merged 15 commits into from Feb 13, 2023

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Jan 16, 2022

Adds the permission essentials.commandcooldowns.bypass.<command name> to bypass the cooldown for a specific command.

Closes #4747

@JRoy JRoy added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module labels Jan 16, 2022
@JRoy JRoy added this to the 2.20.0 milestone Jan 16, 2022
Copy link
Member

@pop4959 pop4959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick but otherwise looks good

…yerListener.java

Co-authored-by: pop4959 <pop4959@gmail.com>
Copy link

@matipoirierg matipoirierg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been testing this for months, working fine without issues.

@mdcfe mdcfe enabled auto-merge (squash) February 13, 2023 23:14
@mdcfe mdcfe merged commit 25ad8ac into EssentialsX:2.x Feb 13, 2023
Chris6ix added a commit to Chris6ix/essinfo.xeya.me that referenced this pull request Feb 14, 2023
Adds the new permission from EssentialsX/Essentials#4759
Removes the separate cooldown bypass permissions for `/heal`, `/feed`, `/tpa` and `/back` as they are now redundant.
@JRoy JRoy deleted the feat/per-command-cooldown-bypass branch February 16, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't override /back cooldown using permissions.
4 participants