Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asynchronously filter commands on Paper when possible #4460

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Asynchronously filter commands on Paper when possible #4460

merged 4 commits into from
Sep 15, 2021

Conversation

mdcfe
Copy link
Member

@mdcfe mdcfe commented Aug 12, 2021

Information

This PR does not close an open issue.

Details

Proposed feature:
Use Paper's async command send API to filter commands out of Brigadier command suggestions.

Environments tested: (TODO)

OS:

Java version:

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

@mdcfe mdcfe added this to the 2.19.1 milestone Aug 12, 2021
@JRoy
Merge branch '2.x' into feature/paper-async-command-send
6caa2fa 
# Conflicts:
#	Essentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java
@JRoy JRoy added module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests. labels Aug 12, 2021
JRoy and others added 2 commits September 15, 2021 16:57
@JRoy JRoy marked this pull request as ready for review September 15, 2021 21:12
@JRoy
Copy link
Member

JRoy commented Sep 15, 2021 •
edited
Loading

Tested on the following versions to work as expected:
Paper 1.17.1
Spigot 1.17.1
Paper 1.13.2

@JRoy JRoy changed the title Use Paper async event to filter commands when available Asynchronously filter commands on Paper when possible Sep 15, 2021
@JRoy JRoy merged commit f0da17b into 2.x Sep 15, 2021
@JRoy JRoy deleted the feature/paper-async-command-send branch September 15, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRoy JRoy JRoy approved these changes

Assignees
No one assigned
Labels
module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.
Projects
None yet
Milestone
2.19.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mdcfe @JRoy