-
-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Minecraft 1.20.6 #5783
Conversation
This comment was marked as spam.
This comment was marked as spam.
72d095e
to
bb9c63c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, changes look good. I noticed, however, that the following exception is still being printed in console when using /give
. Perhaps that'd be something to address (or wait for Paper to resolve) before merging?
[00:27:06 ERROR]: [org.bukkit.craftbukkit.util.CraftMagicNumbers] null
com.mojang.brigadier.exceptions.CommandSyntaxException: Unknown item 'minecraft:' at position 0: <--[HERE]
Correct me if im wrong, but im pretty sure that the |
the exception is unrelated to this and it is a (harmless) bukkit bug, nothing essentials can quite control. |
I've encountered this with my plugin when I used For example, this prints the Bukkit.getUnsafe().modifyItemStack(head, "[minecraft:profile={properties:[{name:\"textures\",value:\"" + base64 + "\"}]}]"); This does not: Bukkit.getUnsafe().modifyItemStack(head, "minecraft:player_head[minecraft:profile={properties:[{name:\"textures\",value:\"" + base64 + "\"}]}]"); Previously, in 1.20.4, we did not need to include the item type: Bukkit.getUnsafe().modifyItemStack(head, "{SkullOwner: {Properties: {textures: [{Value: \"" + base64 + "\"}]}}}"); Most likely this is already known by Essentials devs but I thought I'd leave it here if anyone else is looking up this problem. |
im noticing some potions in kits do not work (all types instant damage pots, there might be more). They show up as "null" when trying to create it |
The issue with potions in kits, including instant damage potions (potion of harming), has been addressed in the latest commits to the mc/1.20.5 branch. Ensure you have pulled the latest changes from this branch and rebuilt the plugin. This should resolve potions showing up as null. |
i am on the latest version of that branch and it still occurs. Server version: 1.20.6-R0.1-SNAPSHOT 1.20.6-89-d3ffa62 (MC: 1.20.6) |
when the server is stopped, delete the items.json file in the plugins/Essentials folder. When you start it, the issue should be resolved. This will happen automatically once merged |
Essentials/src/main/java/com/earth2me/essentials/MetaItemStack.java
Outdated
Show resolved
Hide resolved
providers/BaseProviders/src/main/java/net/ess3/provider/providers/BaseBannerDataProvider.java
Show resolved
Hide resolved
There has been a method for this since 1.13. Why have we been using this for so long? Since item NBT is now dead, this method for checking if an item is spawn-able is defunct and produces a console error every time the give command is ran.
this compiles and probably works but there is some things still left to do