Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Village Steam Heaters orphaned/duplicated #294

Closed
elifoster opened this issue Aug 4, 2015 · 3 comments
Closed

Village Steam Heaters orphaned/duplicated #294

elifoster opened this issue Aug 4, 2015 · 3 comments
Labels
Performance Priority: High Type: Bug
Projects
Bugs
Milestone
0.29.0

Comments

@elifoster
Copy link
Member

Steam Heater tile entities that are spawned in villages are being duplicated, which will very easily cause a memory leak.

Opis screenshot
@elifoster elifoster added this to the 0.28.10 milestone Aug 4, 2015
@elifoster elifoster changed the title Steam Heater memory duplication Steam Heater orphaned/duplicated Aug 4, 2015
@elifoster
Copy link
Member Author

Currently unable to reproduce this issue

@elifoster elifoster changed the title Steam Heater orphaned/duplicated Village Steam Heaters orphaned/duplicated Aug 10, 2015
@elifoster
Copy link
Member Author

This is currently untested by myself or an Esteemed Innovation Team member, but according to the original bug reporter, this bug is not present with Steam Heaters grabbed from NEI/creative or crafted. This bug is only present when the Steam Heater is spawned by a village. The bug allegedly persists after being broken and re-placed somewhere else. This makes the bug much more weird, but potentially easier to fix.

@elifoster elifoster modified the milestones: 0.28.11, 0.28.10 Aug 13, 2015
@elifoster
Copy link
Member Author

I have confirmed that this bug is present in the latest version of FSP.

@elifoster elifoster modified the milestones: 0.29.0, 0.28.11 Aug 28, 2015
@elifoster elifoster added the Status: Approved Has been approved and is ready to be implemented, or has been confirmed to be a bug label Oct 19, 2015
@elifoster elifoster added Status: In Progress Is being worked on currently and removed Status: Approved Has been approved and is ready to be implemented, or has been confirmed to be a bug labels Nov 7, 2015
@elifoster elifoster removed the Status: In Progress Is being worked on currently label Nov 7, 2015
elifoster added a commit that referenced this issue Nov 14, 2015
@elifoster
Removed unused imports. Fix #294.
c237d99
@elifoster elifoster mentioned this issue May 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Performance Priority: High Type: Bug
Projects
Bugs
Resolved
Milestone
0.29.0
Development

No branches or pull requests
1 participant
@elifoster