Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] Dressing tests coveralls #1036

Merged
merged 10 commits into from
Jan 31, 2024

Conversation

vsabatie
Copy link
Collaborator

No description provided.

@vsabatie vsabatie self-assigned this Jan 30, 2024
@vsabatie vsabatie added the enhancement New feature or request label Jan 30, 2024
@vsabatie vsabatie marked this pull request as ready for review January 31, 2024 10:13
Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi, merci bcp

Copy link
Collaborator

@Badatos Badatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques soucis mineurs de mise en forme des docstrings, sinon OK pour moi.

Pour rapidement voir les soucis de mise en forme des docstrings, je t'invite à installer l'extension flake8-docstrings dans ton environnement Python, cela permet de directement voir les erreurs dans VS Code (ou autre éditeur utilisant Flake8)

pip install flake8-docstrings

pod/dressing/tests/test_utils.py Outdated Show resolved Hide resolved
pod/dressing/tests/test_utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci !

@vsabatie vsabatie requested a review from Badatos January 31, 2024 10:48
Copy link
Collaborator

@Badatos Badatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci :)
J'ai hate de voir notre nouveau taux de couverture !

@ptitloup ptitloup merged commit 905d047 into EsupPortail:develop Jan 31, 2024
5 checks passed
vsabatie added a commit to vsabatie/Pod that referenced this pull request Feb 5, 2024
* add unit tests

* fix

* fix flake

* fix

* tests for dressing_create

* fix

* fix

* fix

* add utils

* fix
@vsabatie vsabatie deleted the dressing_tests_coveralls branch February 5, 2024 10:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants