[DONE] add coveralls in pod-encoding action #1067

ptitloup · 2024-03-05T15:29:49Z

Before sending your pull request, make sure the following are done :

You have read our contribution guidelines.
Your PR targets the develop branch.
The title of your PR starts with [WIP] or [DONE].

…pod.yml

…encoding yml to put it in pod.yml

…line to add 11y test

…constraint

…live

ptitloup

Il manque pod_main.yml

…o ptitloup/test_coveralls

…v, add main to test in 3.8 and 3.10

Badatos

quelques questions mineures, sinon code Ok pour moi ;)

Badatos · 2024-03-11T15:58:41Z

.github/workflows/pod_dev.yml

+  DJANGO_SUPERUSER_PASSWORD: "passwd"
+  DJANGO_SUPERUSER_EMAIL: "noreplay@uni.fr"
+  ELASTICSEARCH_TAG: "elasticsearch:7.17.18"
+  ELASTICSEARCH_VERION: "elasticsearch:7.17.18"


VERSIOn plutot que "VERION" non ? :)
Pourquoi avoir 2 variables (TAG et VERION) ?

Badatos · 2024-03-11T16:03:09Z

dockerfile-dev-with-volumes/pa11y-ci/config.json

+        "http://pod-back:8080/video/0001-video-test/",
+        "http://pod-back:8080/live/events/"
+    ]
+}


manque une ligne vide en fin de fichier

Badatos · 2024-03-11T16:03:24Z

dockerfile-dev-with-volumes/pa11y-ci/config_mobile.json

+        "http://pod-back:8080/video/0001-video-test/",
+        "http://pod-back:8080/live/events/"
+    ]
+}


manque une ligne vide en fin de fichier

Badatos · 2024-03-11T16:03:34Z

dockerfile-dev-with-volumes/pa11y-ci/dockerfile-pa11y-ci

+COPY ./dockerfile-dev-with-volumes/pa11y-ci/my-entrypoint-pa11y.sh /tmp/my-entrypoint-pa11y.sh
+RUN chmod 755 /tmp/my-entrypoint-pa11y.sh
+# ENTRYPOINT ["pa11y-ci", "-c", "/usr/config.json"]
+ENTRYPOINT ["bash", "/tmp/my-entrypoint-pa11y.sh"]


manque une ligne vide en fin de fichier

Badatos · 2024-03-11T16:03:37Z

dockerfile-dev-with-volumes/pa11y-ci/my-entrypoint-pa11y.sh

@@ -0,0 +1,3 @@
+#!/bin/sh
+echo "Launching commands into pa11y : pa11y-ci -c /usr/config.json"
+sleep infinity


manque une ligne vide en fin de fichier

Badatos · 2024-03-11T16:03:54Z

dockerfile-dev-with-volumes/pa11y-ci/my-entrypoint-pa11y.sh

@@ -0,0 +1,3 @@
+#!/bin/sh
+echo "Launching commands into pa11y : pa11y-ci -c /usr/config.json"


pas d'espace avant les double points en anglais

Badatos · 2024-03-11T16:10:06Z

pod/video_encode_transcript/tests/test_remote_encode_transcode.py

+            n = 0
+            while self.video.encoding_in_progress:
+                print(
+                    "... Transcripting in progress : %s " % self.video.get_encoding_step


pas d'espace avant les double-points en anglais

Badatos · 2024-03-11T16:15:02Z

Attention, j'ai l'impression qu'en ayant retiré le "Check for pa11y failures" , s'il y a des erreurs A11y, elle seront transparentes et on ne les verra plus :/

- name: Check for pa11y failures.
         if: contains(steps.pa11y_output.outputs.content, 'Errors in http://')
         run: |
           echo "::error::The site is failing accessibility tests. Please review the comment in the pull request or the pa11y-ci step in the workflow for details."
           exit 1

Badatos

mettre à jour actions/setup-node@v3 en actions/setup-node@v4

Badatos · 2024-03-11T16:18:55Z

.github/workflows/pod_dev.yml

+
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 19


Attention :

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

comprend pas, je peux laisser 19 ou c'est mieux de mettre 20 ?

ptitloup · 2024-03-12T09:15:08Z

Attention, j'ai l'impression qu'en ayant retiré le "Check for pa11y failures" , s'il y a des erreurs A11y, elle seront transparentes et on ne les verra plus :/
- name: Check for pa11y failures.
         if: contains(steps.pa11y_output.outputs.content, 'Errors in http://')
         run: |
           echo "::error::The site is failing accessibility tests. Please review the comment in the pull request or the pa11y-ci step in the workflow for details."
           exit 1

Nope, s'il y a des erreurs, pa11y-ci sort avec le code 2 ce qui stop les tests

… before ':'

LoicBonavent

Pour ma part, après les points remontés par Olivier et modifiés, cela me semble bon.
Après, c'est sûr qu'un max-complexity plus élevé serait top :)

add coveralls in pod-encoding action

6275c31

ptitloup self-assigned this Mar 5, 2024

ptitloup added 28 commits March 5, 2024 16:53

export token

17b28dc

add token

e22171e

remove it

30704a9

add coveralls

d0afead

add python and install requirements - remove unused requierements in …

a66129b

…pod.yml

remove command from omit files in coverage

2f05d6a

add unit test to test remote encode - add db to do this - remove pod-…

991d963

…encoding yml to put it in pod.yml

add test to transcripting

0bffc48

fix tear down

69dba98

remove other version of python - change ES port to 9300

f1d88be

create dev pipeline with full test

9479b21

fix python version

07b9579

create main test - use default port for ES

cd3dda0

improve pipeline

8a94096

test access denied

c1a1b4b

add change owner for file created by docker

f77660f

add more clean at the end of docker test

fd51fb2

test keep data from docker to run test with coverage

3acf964

add config test to adddocker to run pa11y - change github action pipe…

95aafd4

…line to add 11y test

remove test settings for pa11y

8c537cb

add volume to pa11y and change username for fixtures to prevent uniq …

9ccd6b8

…constraint

add pa11y docker in config - run it and show result

2361a40

fix docker env

5277f1d

fix docker compose test

5405630

update pa11y config

b5af25e

add delete db_remote in makefile, fix get_video_qrcode for video and …

3c55d09

…live

fucking flake

014f0c9

fix docker down

f256fcd

ptitloup changed the title ~~[WIP] add coveralls in pod-encoding action~~ [DONE] add coveralls in pod-encoding action Mar 11, 2024

ptitloup commented Mar 11, 2024

View reviewed changes

ptitloup added 2 commits March 11, 2024 13:44

Merge branch 'develop' of https://github.com/EsupPortail/Esup-Pod int…

696578c

…o ptitloup/test_coveralls

remove old pa11y config, add new one for mobile and call it in pod_de…

ed99a8d

…v, add main to test in 3.8 and 3.10

LoicBonavent self-requested a review March 11, 2024 15:09

Badatos approved these changes Mar 11, 2024

View reviewed changes

Badatos requested changes Mar 11, 2024

View reviewed changes

remove firefox and geckodriver initially added for selenium testing

76395d7

ptitloup added 2 commits March 12, 2024 10:21

add blanck line at the end of file, remove unused env and white space…

30d1a3d

… before ':'

update node version

37373ab

LoicBonavent approved these changes Mar 12, 2024

View reviewed changes

Badatos approved these changes Mar 12, 2024

View reviewed changes

ptitloup merged commit 93300ef into develop Mar 12, 2024
5 checks passed

ptitloup deleted the ptitloup/test_coveralls branch April 8, 2024 14:23

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DONE] add coveralls in pod-encoding action #1067

[DONE] add coveralls in pod-encoding action #1067

ptitloup commented Mar 5, 2024

ptitloup left a comment

Badatos left a comment

Badatos Mar 11, 2024

Badatos Mar 11, 2024

Badatos Mar 11, 2024

Badatos Mar 11, 2024

Badatos Mar 11, 2024

Badatos Mar 11, 2024

Badatos Mar 11, 2024

Badatos commented Mar 11, 2024 •

edited

Loading

Badatos left a comment

Badatos Mar 11, 2024

ptitloup Mar 12, 2024

ptitloup commented Mar 12, 2024

LoicBonavent left a comment

		@@ -0,0 +1,3 @@
		#!/bin/sh
		echo "Launching commands into pa11y : pa11y-ci -c /usr/config.json"

[DONE] add coveralls in pod-encoding action #1067

[DONE] add coveralls in pod-encoding action #1067

Conversation

ptitloup commented Mar 5, 2024

ptitloup left a comment

Choose a reason for hiding this comment

Badatos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Badatos commented Mar 11, 2024 • edited Loading

Badatos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ptitloup commented Mar 12, 2024

LoicBonavent left a comment

Choose a reason for hiding this comment

Badatos commented Mar 11, 2024 •

edited

Loading