[DONE] Correct some typos + visual bug on video cards icons #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wrong quotes * strong instead of b * nbsp * Simplify some texts
AymericJak
requested changes
Jul 18, 2024
| @@ -77,7 +77,9 @@ <h3>{% trans "Are you sure you want to perform a BigBlueButton live?" %}</h3> | |||
| {% endspaceless %} | |||
| {% endfor %} | |||
| </fieldset> | |||
| <small class="form-text">{% trans 'Please note: shortly after clicking the "Perform a BigBlueButton live" button, the live stream will be available to users on the <i class=\"bi bi-broadcast\"></i> <b>Lives</b> page.' %}</small><br> | |||
| <small class="form-text"> | |||
| {% trans 'Please note: shortly after clicking the “Perform a BigBlueButton live” button, the live stream will be available to users on the <i class="bi bi-broadcast" aria-hidden="true"></i> <strong>Lives</strong> page.' %} | |||
There was a problem hiding this comment.
></i> <strong>Lives</strong>
Est ce que ce serait mieux d'ajouter un après la balise i ?
pod/locale/fr/LC_MESSAGES/django.po
Outdated
| @@ -9913,6 +9958,10 @@ msgstr "Contenu audio." | |||
| msgid "Select video “%(video_title)s”" | |||
| msgstr "Sélectionner la vidéo « %(video_title)s »" | |||
|
|
|||
| #: pod/video/templates/videos/card_select.html | |||
| msgid "Video duration" | |||
| msgstr "Durée totale de la vidéo" | |||
There was a problem hiding this comment.
C'est juste Durée de la vidéo
SebastienCozeDev
approved these changes
Jul 18, 2024
Merci pour tes reviews de qualité ;) |
+ correct "caracters" typo
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct smalls typos :
📝 Add missing help texts
🐛 Correct bug on video cards icons