[DONE] A11y for 3.3.x #887
Merged
+218
−610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ force long video titles to wrap on a second line
+ some cleanup on podfile folder list template
…ady hide if not show) * replace wrong aria-expanded="true" by aria-expanded="false" * move wrongly place title attribute
+ auto wrap footer links on small screens
+ fix some a11y pb
# Conflicts: # requirements-conteneur.txt
AymericJak
approved these changes
Jul 3, 2023
pampletousse
reviewed
Jul 3, 2023
| @@ -3,6 +3,14 @@ | |||
|
|
|||
| if (typeof loaded == "undefined") { | |||
| loaded = true; | |||
|
|
|||
There was a problem hiding this comment.
Possibilité de réutiliser le loader que j'ai essayé de mutualiser pour tous les écrans ?
pod/templates/main/loader.html
There was a problem hiding this comment.
J'ai justement repris le contenu de loader.html ici pour uniformiser, mais je n'avais pas le temps de complètement le changer pour charger le template en dehors du javascript :/
vsabatie
pushed a commit
to vsabatie/Pod
that referenced
this pull request
Aug 30, 2023
* CSS: prevent default thumbnail to be too small on some screens + force long video titles to wrap on a second line * Improve some contrast colors + some cleanup on podfile folder list template * * remove useless "collapse hide" class combination (.collapse is already hide if not show) * replace wrong aria-expanded="true" by aria-expanded="false" * move wrongly place title attribute * add missing "lang" attribute + auto wrap footer links on small screens * prune a lot of useless code in podfile.css + fix some a11y pb * replace podfile loader by pod main loader
LoanR
pushed a commit
to yaal-coop/Esup-Pod
that referenced
this pull request
Aug 30, 2023
* CSS: prevent default thumbnail to be too small on some screens + force long video titles to wrap on a second line * Improve some contrast colors + some cleanup on podfile folder list template * * remove useless "collapse hide" class combination (.collapse is already hide if not show) * replace wrong aria-expanded="true" by aria-expanded="false" * move wrongly place title attribute * add missing "lang" attribute + auto wrap footer links on small screens * prune a lot of useless code in podfile.css + fix some a11y pb * replace podfile loader by pod main loader
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to improve global Accessibility of Esup-Pod :