[DONE] Fix : Accessibility for the media compatibility with the assistive tools (04.13) #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merci pour cette nouvelle PR :) Au passage, qui est l'auteur de l'image default-playlist.svg ? pod/playlist/static/playlist/img/default-playlist.svg Il faudra l'indiquer ainsi que la licence dans les crédits de Pod. |
…compatibility_with_assistive_tools
…compatibility_with_assistive_tools
SebastienCozeDev
changed the title
SebastienCozeDev
changed the title
…compatibility_with_assistive_tools
SebastienCozeDev
changed the title
AymericJak
reviewed
Aug 30, 2023
Je suis d'accord avec la remarque de Aymeric. J'aurais egalement mis "avancer de 10 seconde dans la vidéo" et "reculer de 10 secondes dans la vidéos" |
Badatos
reviewed
Aug 30, 2023
|
|
||
| #: pod/video/static/js/video-show.js | ||
| msgid "Seek forward 10 seconds in the video" | ||
| msgstr "Avancer de 10 secondes dans le video" |
There was a problem hiding this comment.
C'est réglé
AymericJak
approved these changes
Aug 30, 2023
Badatos
approved these changes
Aug 30, 2023
18 tasks
vsabatie
pushed a commit
to vsabatie/Pod
that referenced
this pull request
Nov 22, 2023
…tive tools (04.13) (EsupPortail#919) * Add video-show.js for the button translation * Fix the chapter modal * Add the aria-label attribute in the reset track settings button * Translate * Update titles for seek forward & seek back buttons * Fix translation * Fix translation
vsabatie
pushed a commit
to vsabatie/Pod
that referenced
this pull request
Nov 23, 2023
…tive tools (04.13) (EsupPortail#919) * Add video-show.js for the button translation * Fix the chapter modal * Add the aria-label attribute in the reset track settings button * Translate * Update titles for seek forward & seek back buttons * Fix translation * Fix translation
vsabatie
pushed a commit
to vsabatie/Pod
that referenced
this pull request
Nov 23, 2023
…tive tools (04.13) (EsupPortail#919) * Add video-show.js for the button translation * Fix the chapter modal * Add the aria-label attribute in the reset track settings button * Translate * Update titles for seek forward & seek back buttons * Fix translation * Fix translation
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before sending your pull request, make sure the following are done :
developbranch.[WIP]or[DONE].Non-conformité :
Piste de correction :
Dans le dépliant : supprimer le role="menu", attribuer à chaque un role="button" et le rendre activable avec les touches Entrée et Espace, et ajouter sur l’élément non focusable un tabindex="0"