Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1287 Fix drawing of all-day events. #1290

Merged
merged 1 commit into from Dec 28, 2022
Merged

#1287 Fix drawing of all-day events. #1290

merged 1 commit into from Dec 28, 2022

Conversation

RobertZenz
Copy link
Contributor

@RobertZenz RobertZenz commented Dec 27, 2022 •
edited

allDay is the condition I was looking for, it allows to determine whether the event has a time at all.

Two points I'm unsure about:

  1. Did I place the comments correctly or would you prefer it above the if condition.
  2. Are there utility functions for determining whether it is the same day or not? Subtracting and checking the minutes works, but if you've got something better that would be it.

@RobertZenz
Copy link
Contributor Author

On second thought...is < MINUTES_PER_DAY or <= MINUTES_PER_DAY correct? I'd wager <, right?

@RobertZenz RobertZenz force-pushed the fix-allday-events-in-day-week-view branch from b7cbb3c to 3646e6b Compare December 27, 2022 18:33
@RobertZenz RobertZenz mentioned this pull request Dec 28, 2022
Closed
@RobertZenz RobertZenz force-pushed the fix-allday-events-in-day-week-view branch from 3646e6b to f3a9c9f Compare December 28, 2022 13:14
@Gitsaibot Gitsaibot merged commit c6ca3a1 into Etar-Group:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspricke jspricke jspricke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RobertZenz @jspricke @Gitsaibot