Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the distance between swiping left and right to better distingu… #1603

Closed
wants to merge 1 commit into from

Conversation

Gitsaibot
Copy link
Contributor

…ish between scrolling up or down. Fix #1535

@toolstack
Copy link
Contributor

Looks fine to me, 300 work well in my testing. Perhaps a better/alternate solution might be to track the y motion as well and check if the swipe x/y ratio is more up/down than left/right.

@Gitsaibot
Copy link
Contributor Author

Perhaps a better/alternate solution might be to track the y motion as well and check if the swipe x/y ratio is more up/down than left/right.

Yes, that would be a better solution. Would you want to implement this?

@toolstack
Copy link
Contributor

Let me take a look at it, should be simple enough to implement.

@toolstack
Copy link
Contributor

PR #1605 implements the ratio check.

@Gitsaibot
Copy link
Contributor Author

Closed in favor of #1605

@Gitsaibot Gitsaibot closed this Mar 8, 2024
@Gitsaibot Gitsaibot deleted the swipe branch April 2, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrolling down scrolls back up
2 participants