GH-107 Add configurable notifications #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoyek
approved these changes
Nov 2, 2023
CitralFlo
approved these changes
Nov 3, 2023
P1otrulla
approved these changes
Nov 3, 2023
Jakubk15
approved these changes
Nov 4, 2023
vLuckyyy
reviewed
Nov 13, 2023
It will restore the default value from the configuration. |
|
It would be useful to standardize the format of notifications, as here -> https://docs.eternalcode.pl/eternalcore/notifications First I will refactor dependencies to make it easier to add anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration file looks now:
Tested on localhost.
Additionally, I suggest to remove the SUB_TITLE notification type. And replace it with a standard TITLE notification, which will have the title and subtitle string arguments - if someone wants only the subtitle, they will leave the title message empty and the same with the title. Give your opinion.