-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing app freeze after 2nd share (iOS 12) #12
Comments
Ditto. Trying to dig in to figure out what's going on but I'm not an iOS dev so I don't know enough about the app lifecycle to really figure out what's going on. What it seems is that the invisible window (layer? layout? storyboard?) is blocking the rest of the app. I put on DEBUG level logging, and didn't learn anything new. Still digging to see what I can find! |
I got it! Here's what you need to change:
What you want to do is basically move the viewDidLoad content to the viewDidAppear body. So remove the closing } of viewDidAppear and the
if you want to be correct, change the debug statement to viewDidAppear instead of viewDidLoad. But whatever! Doing that solves the problem. You still see a brief flash of the share dialog on the second share as it's switching to your app, but that's a-ok with me for now. |
Here's my PR for the fix. If you look at the diff, you'll see the changes: #13 |
Tried and seems to work for me :) |
Thank you. I was having issues with the iOS Files app freezing when I attempted to share items from there, as well. This fixed it. |
PR isn't getting merged by repo owner. If you want to use my working version, you can do FWIW I'm currently using @ygy6g70 's repository at |
Freze iOS Fix, see EternallLight#12 (comment)
@grexican thank you very much for the suggested fix! It will be included in the version 2 of the plugin |
This started happening with iOS 12
2nd time I share Safari page I get this dialog, and when canceling the Safari is frozen and I have to kill it (see attachment)
The text was updated successfully, but these errors were encountered: