feat: usePresenceSwitch cleanup
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| getByTestId('none'); | ||
| getByText('Nothing mounted'); | ||
| rerender(<Expander text="initial value" />); | ||
| getByTestId('isAnimating, isEntering, isMounted'); | ||
| getByText('initial value'); | ||
| await waitFor(() => getByTestId('isVisible, isMounted')); | ||
| rerender(<Expander text={null} />); | ||
| rerender(<Expander text={undefined} />); |
There was a problem hiding this comment.
I originally did this but the tests complained in a warning and told me to use null
| mountedItem | ||
| }; | ||
| } | ||
|
|
||
| function isNil<ItemType>(value: ItemType) { | ||
| return value == null; | ||
| function isUndefined<ItemType>(value: ItemType) { |
There was a problem hiding this comment.
So I'm fine with this, but at this point, I feel like I lean towards just using item === undefined or item !== undefined in places rather than having the extra function 😅
EthanStandel
approved these changes
Feb 10, 2023
|
So feel free to merge this as you please, I just added a couple "food for thought" comments but it's nothing that affects the usability of the feature for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, here are some changes I'd propose to simplify and clean up the README a bit.
I'd also reduce the API surface to not handle
nullin a special way, maybe there's a use case where this is expected to be an actual value.Let me know if this works for you!