Add member metadata and flip card (2nd variant) #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
diamondburned
force-pushed
the
member-card2
branch
from
c2b5153
to
d370ac9
Compare
diamondburned
force-pushed
the
member-card2
branch
from
d370ac9
to
af609ea
Compare
diamondburned
force-pushed
the
member-card2
branch
from
af609ea
to
0486202
Compare
diamondburned
force-pushed
the
member-card2
branch
from
0486202
to
4420917
Compare
diamondburned
force-pushed
the
member-card2
branch
2 times, most recently
from
5566e9f
to
19ed24e
Compare
diamondburned
force-pushed
the
member-card2
branch
from
19ed24e
to
7f20365
Compare
diamondburned
force-pushed
the
member-card2
branch
from
7f20365
to
5f5e30e
Compare
diamondburned
force-pushed
the
member-card2
branch
from
5f5e30e
to
75037c1
Compare
diamondburned
force-pushed
the
member-card2
branch
from
75037c1
to
bd62bbd
Compare
|
|
diamondburned
force-pushed
the
member-card2
branch
from
bd62bbd
to
52fe658
Compare
diamondburned
force-pushed
the
member-card2
branch
from
52fe658
to
4c45ca3
Compare
diamondburned
force-pushed
the
member-card2
branch
from
858f34d
to
e8cda32
Compare
diamondburned
force-pushed
the
member-card2
branch
from
e8cda32
to
fb130dc
Compare
diamondburned
force-pushed
the
member-card2
branch
from
fb130dc
to
6fb4197
Compare
diamondburned
force-pushed
the
member-card2
branch
from
6fb4197
to
88e3967
Compare
diamondburned
force-pushed
the
member-card2
branch
from
88e3967
to
883ce7a
Compare
diamondburned
force-pushed
the
member-card2
branch
from
883ce7a
to
273a2e6
Compare
diamondburned
force-pushed
the
member-card2
branch
from
273a2e6
to
eab3ff0
Compare
diamondburned
force-pushed
the
member-card2
branch
from
eab3ff0
to
9d03bb7
Compare
diamondburned
force-pushed
the
member-card2
branch
from
9d03bb7
to
9cf4b59
Compare
EthanThatOneKid
approved these changes
Oct 7, 2022
Apparently $.displayName wasn't used for anything useful other than for GitHub usernames, which is now replaced by $.socials.github
toast.beforeFunc is a bit more convenient to use than writing a try-catch syntax. This used to be called toastDo with a much better function API, but there were some trivial disagreements. This commit also removes ToastType.Info, because it behaves similarly to ToastType.Success (acmGeneral color), and Info was never used anywhere. This commit also makes ToastType actually behave in a useful manner (previously, the border colors don't follow the ToastType).
- GitHub is taken from https://ant.design/components/icon/ - Public is taken from https://fonts.google.com/icons (filled) - Some icons have their fill attribute fixed
Also refactor some Svelte HTML logic for additional styling.
diamondburned
force-pushed
the
member-card2
branch
from
9cf4b59
to
5a060ed
Compare
| @@ -9,41 +17,168 @@ | |||
| export let info: Officer; | |||
| export let placeholderPicture = 'placeholder.webp'; | |||
| export let dev = false; | |||
There was a problem hiding this comment.
Note: Variable used to determine whether the dev server is enabled can be imported like so:
import { dev } from '$app/environment';See: https://kit.svelte.dev/docs/modules#$app-environment-dev.
There was a problem hiding this comment.
I'm actually not sure why this was here in the first place. I didn't touch it in any meaningful way.
There was a problem hiding this comment.
I'm actually not sure why this was here in the first place. I didn't touch it in any meaningful way.
All good. I believe it is being followed up in #612.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design 2: the small member image flips to reveal the backside of itself.
Sibling: #596
For preview, go to the About page. Flip cards are available for @EthanThatOneKid, @AlanCortez1337 and @diamondburned.
TODO