Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI/UX] Studio Update - Tailwind components for studio #10075

Merged
merged 274 commits into from
May 30, 2024
Merged

[UI/UX] Studio Update - Tailwind components for studio #10075

merged 274 commits into from
May 30, 2024

Conversation

aditya-mitra
Copy link
Collaborator

@aditya-mitra aditya-mitra commented Apr 18, 2024 •
edited

Summary

the new studio is present in /studio route
and the old studio is present in /studio-old route

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

@aditya-mitra aditya-mitra mentioned this pull request Apr 18, 2024
Closed
HexaField
HexaField requested changes Apr 18, 2024
View reviewed changes
packages/editor/tsconfig.json Outdated Show resolved Hide resolved
@HexaField HexaField changed the title tailwind components for studio advanced mode Tailwind components for studio Apr 18, 2024
aditya-mitra and others added 19 commits April 18, 2024 11:06
@aditya-mitra
correct checkbox and extend its props
910845e
@aditya-mitra
remove editor tsconfig changes
b2c7821
@aditya-mitra
match boolean input checkbox with foundation design
096475f
@SYBIOTE
Merge branch 'dev' into advanced-mode
4b6c67a
@SYBIOTE
light node editors, partial
2a5e98f
@aditya-mitra
remove override usage
c7d4062
@aditya-mitra
Merge remote-tracking branch 'origin/advanced-mode' into advanced-mode
a4a998a
@aditya-mitra
added the color input
f0bd32f
@aditya-mitra
added colorinput to ambient light editor
0f676ff
@aditya-mitra
added colorinput and corrected checkbox alignment
0700413
@SYBIOTE
interaction node editors and fixes
93df81a
@aditya-mitra
Merge branch 'dev' into advanced-mode
7b42fbf
@aditya-mitra
added media node editor and array input group
b17591f
@aditya-mitra
Merge branch 'dev' into advanced-mode
302bd45
@SYBIOTE
rename color input to color and remove from input folder
82d2ba1
@aditya-mitra
fix string input to match design
d8beec1
@aditya-mitra
Merge remote-tracking branch 'origin/advanced-mode' into advanced-mode
9dddad0
@aditya-mitra
load dark theme by default
7315171
@aditya-mitra
match select input with design
6efafab
aditya-mitra and others added 13 commits May 29, 2024 17:32
@aditya-mitra
implement assets category tree view
a71c6fd
@SYBIOTE
Merge branch 'dev' into advanced-mode
f83f4d4
@SYBIOTE
adjust slider to correct dynamic styling
ebfd566
@aditya-mitra
revert tailwind select
f5fdda3
@aditya-mitra
revert tooltip
9c3c0cb
@aditya-mitra
fix all lint errors
551cae4
@aditya-mitra
Merge branch 'dev' into advanced-mode
5d31dfb
@aditya-mitra
fix dev lint errors
d4e6240
@aditya-mitra
automated prettier format
d5ebdad
@SYBIOTE
fix slider
1650943
@SYBIOTE
Merge branches 'advanced-mode' and 'advanced-mode' of https://github.…
306be4b 
…com/EtherealEngine/etherealengine into advanced-mode
@SYBIOTE
fix incorrect component editor
4bf77e2
@aditya-mitra @DanielBelmes
fix miscellaneous bugs for the new studio (#10280)
05ac44b 
* do not activate files panel when deleting scene

* fix scenes vanishing after renaming

* correct rename scene modal to have the full renamed url

* fix asset search to display results

* fix Settings

---------

Co-authored-by: Daniel Belmes <danielbelmes@ymail.com>
@DanielBelmes DanielBelmes changed the title Tailwind components for studio [UI/UX] Studio Update - Tailwind components for studio May 30, 2024
dinomut1
dinomut1 previously requested changes May 30, 2024
View reviewed changes
Copy link
Member

@dinomut1 dinomut1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

studio-old bugs:

Add Entity dropdown broken

Add Component dropdown broken

File browser settings:
-cannot close modal, locks camera while open
-slider doesn't work
-generate thumbnails button doesn't work

Top left dropdown:
-only "New Scene" button works (very difficult to click on, only successful once). Clicks through every other option
-dropdown doesn't close, locks camera while open

loop animation node editor crashes studio

@DanielBelmes
Copy link
Contributor

studio-old bugs:

Add Entity dropdown broken

Add Component dropdown broken

File browser settings: -cannot close modal, locks camera while open -slider doesn't work -generate thumbnails button doesn't work

Top left dropdown: -only "New Scene" button works (very difficult to click on, only successful once). Clicks through every other option -dropdown doesn't close, locks camera while open

loop animation node editor crashes studio

RESOLVED

@DanielBelmes DanielBelmes dismissed stale reviews from dinomut1 and HexaField May 30, 2024 21:16

fixed

@DanielBelmes DanielBelmes added this pull request to the merge queue May 30, 2024
Merged via the queue into dev with commit d36c9c6 May 30, 2024
13 checks passed
@DanielBelmes DanielBelmes deleted the advanced-mode branch May 30, 2024 21:16
@aditya-mitra aditya-mitra mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYBIOTE SYBIOTE SYBIOTE left review comments

@DanielBelmes DanielBelmes DanielBelmes approved these changes

@dinomut1 dinomut1 Awaiting requested review from dinomut1

@HexaField HexaField Awaiting requested review from HexaField

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aditya-mitra @DanielBelmes @HexaField @SYBIOTE @dinomut1 @achen5671 @dtlehrer