Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix miscellaneous bugs for the new studio #10280

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

aditya-mitra
Copy link
Collaborator

Summary

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

@aditya-mitra aditya-mitra changed the base branch from dev to advanced-mode May 30, 2024 07:19
@aditya-mitra aditya-mitra marked this pull request as ready for review May 30, 2024 12:22
Copy link
Member

@SYBIOTE SYBIOTE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@DanielBelmes DanielBelmes merged commit 05ac44b into advanced-mode May 30, 2024
2 checks passed
@DanielBelmes DanielBelmes deleted the fix/adv-bugs branch May 30, 2024 19:02
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2024
* add ovverride to checkbox story

* file browser, texture, image  and image preview,  input group partial

* remove type errors with override

* audio, folder, material , model and prefab

* add default props

* progress bar

* transform node editor

* correct checkbox and extend its props

* remove editor tsconfig changes

* match boolean input checkbox with foundation design

* light node editors, partial

* remove override usage

* added the color input

* added colorinput to ambient light editor

* added colorinput and corrected checkbox alignment

* interaction node editors  and fixes

* added media node editor and array input group

* rename color input to color and remove from input folder

* fix string input to match design

* load dark theme by default

* match select input with design

* misc node editors

* remove document styles and add wekbit slider and moz range classes to slider

* fix and simplify numeric input

* fix boolean input border

* gallery node editor

* fix string input height

* fix string input alignment

* revert link editor inputs

* image grid and volumetric node editor

* particle node editor

* fix gallery and image grid for heading positioning

* added the collider and trigger editors

* added license

* added the textbox editor

* simplify the styles for input group and make it more adherent to the design

* simplify property group and node editor

* fix css in editors

* properties panel

* properties panel ,  replace old properties with new ones in ComponentEditorsState

* add comments

* comment out portal path to prevent errors

* viewport panel partial

* add viewport panel title

* icons for component editors

* finished viewport panel

* add License

* scene panel partial

* add License

* add panel titles

* fix title content

* designs for new scene panel, partial functionality

* heirachy panel partial

* added editor 2 route as `/studio2`

* added editor2container

* heirachy panel

* get page showing

* remove comments from node editors

* remove comments from panels

* fix scene panel index

* make tool bar partial

* minor adjustment to dock designs

* make the toolbar more adherent

* fixed the panel fonts

* introduce project page before studio

* fix scenes panel

* engine canvas in viewport

* added the tools inside viewport

fix panel styles, numeric input

* fixed the viewport fallback

* make the rc-dock pixel perfect

* fix rename in scene panel

* add delete scene functionality

* add clickaway listener

* partiallly function components and heirarchy panel

* polish heirarchy panel

* fix viewport resize

* fix the hierarchy panel styles

* correct the scenes panel

* context menu for heirarchy panel

* add selection border for heirarchy node

* resolve merge conflict

* fix panel z-index

* fix margins between scene thumbnails

* use tailwind buttons on context menu

* added ground plane,collider,rigibbody editors

* added geometry and mesh editors

* fix vector3 input and scrubber

* fixes in collider component

* fix select styles

* minor translation and input fixes

* partial file browser

* add License

* remove material dialog

* correct ts errors in schema

* added save and save as dialogs in new toolbar

* added import settings panel

* completed the toolbar and functionalites

* remove material ui references

* toolbar main menu

* text align left for file table

* component element list

* revert changes to toolbar

* make pointer anchor to canvas space from window space

* center text in element list

* update folder

* fix import errors

* revert changes in editor container

* add missing css in editor2container

* revert unwanted changes in editor package

* highlight file view mode

* refactor file view mode for scalability

* constrain LoadingView size

* fix hierarchy panel styling regressions

* remove unnecessary functionalities and files

* remove accidently added gltf file

* text no wrap on nodename

* dont wrap text

* cleanup with hierarchy menu

* reposition ContextMenu when necessary to avoid bottom overflow

* make the menu scrollable if it is too tall for the parent component

* show cursor-pointer on PanelDragContainer

* update PanelDragContainer

* refactor

* add unique keys to prevent studio warnings

* assets panel new design

* fix imports

* assets categories

* remove comments

* revert tailwind select

* clean up file browse menus

* material panel partial

* fix margin in assets panel

* update FilesPanel text colors

* add overflow to material panel

* `currentValue` in select

* remove unwanted added storybook files

* revert unwanted ui primitives

* stuff

* file browser grid styling + update state onClick

* rm extra left margin

* cleanup

* style dock-tab variants

* add padding to scene overflow

* edit upload assets btn

* style FileBrowserContentPanel

* make the studio and files loading spinner smaller

* correct file browser list view rendering

* revert input and confirmdialog

* add cursor in file browser items

* loader size correction in editor router

* fix trigger component editor

* material editor

* revert changes

* text styling for component list and default transform for all components

* use h-full & w-full

* update breadcrumb cursor + refactor tooltip

* adjust file browser text colors

* Update ContextMenu.tsx

* update scene item dimensions

* style search input

* make viewport pointer realtive to panel

* change studio2 to `studio` and studio to `studio-old`

* remove useAllComponents usages

* remove simple advanced toggle for now

* added render mode tools

* minor styling improvements

* improve render panel

* Move studio registries to a more appropriate directory

* license

* fix import

* remove editor tailwind config

* use tooltips instead of button titles

* implement assets category tree view

* adjust slider to correct dynamic styling

* revert tailwind select

* revert tooltip

* fix all lint errors

* fix dev lint errors

* automated prettier format

* fix slider

* fix incorrect component editor

* fix miscellaneous bugs for the new studio (#10280)

* do not activate files panel when deleting scene

* fix scenes vanishing after renaming

* correct rename scene modal to have the full renamed url

* fix asset search to display results

* fix Settings

---------

Co-authored-by: Daniel Belmes <danielbelmes@ymail.com>

* fix model component stalling studio

* add comp style, fix old pop over

---------

Co-authored-by: sybiote <ghoshr698@gmail.com>
Co-authored-by: Andy Chen <andychen5671@gmail.com>
Co-authored-by: dtlehrer <dtlehrer@csbsju.edu>
Co-authored-by: HexaField <joshfield999@gmail.com>
Co-authored-by: Daniel Belmes <danielbelmes@ymail.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants