Groups chat #345
Merged
Groups chat #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@barankyle - let's pass the CI tests, and merge this into |
Unfriending works.
Users can accept invites from the profile modal.
partyUsers since their logic is intertwined enough to make having separate reducers annoyingly complex.
Front-end chat interface is in rough shape, need to fix state update.
Clicking a message populates its messages in a list. Sending a message triggers an update on that channel's messages.
Started converting Profile modal to drawers.
drawers are not in place. Added logic to groupUser and partyUser fetch logic to track if selfUser and batch user gets are in progress, so that state updates from one do not trigger re-fetches of the other.
Added ability to select friends from a <select> as invite target. Need to fix some Sequelize relationships with groups -> group users.
Added invite validation. Added try/catch statements to all friend/group/party service Feathers calls.
All channels are now fetched together, which requires a semi-complicated custom SQL query plus some additional population of user lists and user avatars. Need to add message patch + deletion. Haven't tested parties.
It should scroll to the bottom of the active chat whenever the drawer is opened. Removed group-user front-end redux service. groupUsers and partyUsers are now fetched as part of the group/party fetching process. Removed all redux things associated with separate fetching of groupUsers, partyUsers, and selfGroupUser/selfPartyUser. selfUser is now just plucked from list of group/partyUsers. Removed Chat/Friends/Groups/Invites/Parties from Profile since they're all more or less working in their drawers. Moved channel publications from top-level 'channels.ts' to the service they're publishing for. Added channel publications for group-user create/patch/remove. Need to add it for parties, and for user updates.
propagating via channel updates. Updated invite email invite button to say 'Accept invite' Corrected onDelete: 'cascade' calls to use 'hooks': true, as that is required for onDelete removal to be called. Added a primary key id to user-relationship, removed PK of combined 'userId' and 'relatedUserId'.
Invite server-side updates working. Turned on deleting of invite once it's accepted. Removed console.log statements and ran through linter. Message status system not yet implemented.
barankyle
approved these changes
Aug 4, 2020
barankyle
pushed a commit
to barankyle/xr3ngine
that referenced
this pull request
Aug 8, 2020
added fuse controls to video camera
This was referenced Aug 14, 2020
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@barankyle's WIP PR.