Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Hand Track / IK Improvements #7920

Merged
merged 16 commits into from
Apr 26, 2023
Merged

Conversation

AidanCaruso
Copy link
Member

Summary

Refines hand tracking, playspace scaling to fit the avatar as a secondary means of hand tracking improvement to ensure the arm length is always adequate.

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@AidanCaruso
Copy link
Member Author

Discarded some of the experimental changes I made to hand target rotation from controller in applyInputSourcePoseToIKTargets.ts, results were not better.

@HexaField HexaField marked this pull request as ready for review April 26, 2023 03:58
@HexaField HexaField merged commit f1b9787 into dev Apr 26, 2023
7 of 8 checks passed
@HexaField HexaField deleted the 7590-avatar-ik-improvements branch April 26, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants