Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a client-side bug with users' avatars missing resources. #7962

Merged
merged 1 commit into from
May 4, 2023

Conversation

barankyle
Copy link
Member

@barankyle barankyle commented May 4, 2023

Summary

Sometimes, a user-patched message is getting sent to the client where the nested avatar object does not have modelResource or thumbnailResource. This was causing errors due to assuming modelResource would always exist.

Workaround is to not assume that, and to attempt to fetch the avatar manually if it is missing modelResource. It will then spawn the avatar from this, and only if this failed to get the necessary information is an error thrown about the avatar missing its model.

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Sometimes, a user-patched message is getting sent to the client
where the nested avatar object does not have modelResource or
thumbnailResource. This was causing errors due to assuming
modelResource would always exist.

Workaround is to not assume that, and to attempt to fetch the
avatar manually if it is missing modelResource. It will then
spawn the avatar from this, and only if this failed to get the
necessary information is an error thrown about the avatar
missing its model.
@barankyle barankyle force-pushed the missing-avatar-resources-fix branch from b3bab6d to 77831b8 Compare May 4, 2023 17:53
@barankyle barankyle marked this pull request as ready for review May 4, 2023 17:54
@speigg speigg added this pull request to the merge queue May 4, 2023
Merged via the queue into dev with commit 09e9ac2 May 4, 2023
7 of 8 checks passed
@speigg speigg deleted the missing-avatar-resources-fix branch May 4, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants