Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a client-side bug with users' avatars missing resources. #7962

Merged
merged 1 commit into from
May 4, 2023
Merged

Fixes a client-side bug with users' avatars missing resources. #7962

merged 1 commit into from
May 4, 2023

Commits on May 4, 2023

  1. Fixes a client-side bug with users' avatars missing resources. 

    Sometimes, a user-patched message is getting sent to the client
where the nested avatar object does not have modelResource or
thumbnailResource. This was causing errors due to assuming
modelResource would always exist.

Workaround is to not assume that, and to attempt to fetch the
avatar manually if it is missing modelResource. It will then
spawn the avatar from this, and only if this failed to get the
necessary information is an error thrown about the avatar
missing its model.
    @barankyle
    barankyle committed May 4, 2023
    Configuration menu
    Copy the full SHA
    77831b8 View commit details
    Browse the repository at this point in the history