Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug with project-permission granting. #8126

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

barankyle
Copy link
Member

@barankyle barankyle commented Jun 23, 2023

Summary

UI for adding a user to a project said to enter Invite Code, but if given a user ID, the error message said invalid user ID or invite code. Updated project.create handler to parse either input parameter and determine if it's really the other, i.e. re-assigning data.inviteCode to data.userId if it detects a UUID on data.inviteCode.

Moved some constant regexes from InviteService.ts to a new IdConstants file in common/src/constants. Updated references to these constants.

References

closes #8123

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

UI for adding a user to a project said to enter Invite Code, but if given
a user ID, the error message said invalid user ID or invite code. Updated
project.create handler to parse either input parameter and determine if it's
really the other, i.e. re-assigning data.inviteCode to data.userId if it
detects a UUID on data.inviteCode.

Moved some constant regexes from InviteService.ts to a new IdConstants file
in common/src/constants. Updated references to these constants.
@HexaField HexaField added this pull request to the merge queue Jun 27, 2023
Merged via the queue into dev with commit 3d83f8b Jun 27, 2023
9 checks passed
@HexaField HexaField deleted the 8123-project-user-add-fix branch June 27, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: UserID error when adding user as project owner
2 participants