Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for avatar service to use schema, knex & feathers 5 #8261

Merged
merged 9 commits into from
Jul 19, 2023
Merged

Changes for avatar service to use schema, knex & feathers 5 #8261

merged 9 commits into from
Jul 19, 2023

Conversation

hanzlamateen
Copy link
Member

Summary

A summary of changes being made in this PR

References

#7645

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@hanzlamateen hanzlamateen marked this pull request as ready for review July 12, 2023 08:02
@hanzlamateen hanzlamateen requested review from HexaField, barankyle and speigg and removed request for HexaField July 12, 2023 08:02
@hanzlamateen hanzlamateen added this pull request to the merge queue Jul 19, 2023
Merged via the queue into dev with commit 28dd289 Jul 19, 2023
9 checks passed
@hanzlamateen hanzlamateen deleted the avatar-feathers5 branch July 19, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barankyle barankyle barankyle approved these changes

@speigg speigg Awaiting requested review from speigg

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hanzlamateen @barankyle