Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8133 studio should have render settings exposed #8263

Merged
merged 11 commits into from
Jul 13, 2023

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Jul 11, 2023

Summary

added fully fleshed checkboxes

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@SYBIOTE SYBIOTE linked an issue Jul 11, 2023 that may be closed by this pull request
@SYBIOTE SYBIOTE requested a review from HexaField July 11, 2023 18:13
…into 8133-studio-should-have-render-settings-exposed
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2023-07-12 15-22-42

This is what was meant by render settings, not the scene render settings. We should buff this out into a modal instead of a dropdown, and include the post processing button.

We then need to add conditions in all the places where the render settings affect the renderer, to use these new editor settings instead of user profile settings when in the editor.

@SYBIOTE
Copy link
Member Author

SYBIOTE commented Jul 12, 2023

Understood, I'm on it, do we also want the settings to disappear from the user config when in editor mode?
And what should we have in the modal?
Use shadows
Use post processing
The render type dropdown
What else?

@HexaField
Copy link
Member

Understood, I'm on it, do we also want the settings to disappear from the user config when in editor mode? And what should we have in the modal? Use shadows Use post processing The render type dropdown What else?

@SYBIOTE
Copy link
Member Author

SYBIOTE commented Jul 12, 2023

for the modal itself, it will appear as a popup box, in the center of screen, taking the focus
in the modal
a checkbox, for use post processing,
under it the resolution
under it the drop down

click outside of modal to return , or i can add a close button

as far as i know, the resolution is for overall graphics
so i wont tie it to a condition ( selected shadows ) and keep it as the second in the modal

EDIT: i handnt pulled latest changes, i understood what shadow map resolution means now, ill adjust the modal accordingly

regarding the changes i made earlier in the scene render settings, should i keep them or revert them, ill revert them if asked to

@SYBIOTE
Copy link
Member Author

SYBIOTE commented Jul 12, 2023

@HexaField HexaField marked this pull request as draft July 13, 2023 22:34
@HexaField HexaField self-requested a review July 13, 2023 22:34
@HexaField HexaField marked this pull request as ready for review July 13, 2023 23:20
@HexaField HexaField enabled auto-merge July 13, 2023 23:20
@HexaField HexaField disabled auto-merge July 13, 2023 23:21
@HexaField HexaField merged commit faaa9cb into dev Jul 13, 2023
8 checks passed
@HexaField HexaField deleted the 8133-studio-should-have-render-settings-exposed branch July 13, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Studio should have render settings exposed
3 participants