feat(graphic user settings): move shadow map resolution to graphic settings #8267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
HexaField
approved these changes
Jul 12, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
* start event sourcing world actions * resolve out of sync problem * things run again * remove refs to spawnDebugPhysicsObject * fix renderer state affecting csm incorrectly * feat(graphic settings): move shadow map resolution to graphic settings (#8267) * Fixed improper generation of Cloudfront route redirects /admin and /studio (also /editor) need to handle both e.g. /admin and /admin/<subroute> Non-builtin route matches are now exact-only, with a `$` at the end, to prevent fuzzy matches that likely wouldn't point to anything. * start event sourcing world actions * resolve out of sync problem * things run again * remove refs to spawnDebugPhysicsObject * tests pass, add reactor render helper * add license * update node env * remove spawn pose component * collapse force render into run function with optional bool * fixes --------- Co-authored-by: Aditya Mitra <55396651+aditya-mitra@users.noreply.github.com> Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move shadow map resolution (which was initially a part of light shadow properties) to user settings menu
References
closes #8170
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.