Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flicker on new entity select #9348

Merged
merged 2 commits into from Nov 29, 2023
Merged

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Nov 29, 2023

This pull request fixes the issue of flickering when selecting a new entity in the CoreNodeEditor component. The flickering was caused by an unnecessary re-rendering of the component due to an unused selectionState variable. This PR removes the unused variable and optimizes the rendering process.

Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great jaerb

@dinomut1 dinomut1 added this pull request to the merge queue Nov 29, 2023
Merged via the queue into dev with commit 8a52fb9 Nov 29, 2023
8 checks passed
@dinomut1 dinomut1 deleted the fix-heirarchy-selction-flicker branch November 29, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants