Fixed bug in LocationDrawer sceneId logic #9480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Location sceneId's are now projects/<projectName>/<sceneName>.scene.json Select for sceneId is just <projectName>/<sceneName> Setting of state.scene in LocationDrawer.tsx was erroring since there were no matches, and then would prepend projects/ and append .scene.json to the sceneId if saved without touching the scene selector, which would then point the location to an invalid scene.
Rezmason
pushed a commit
that referenced
this pull request
Dec 26, 2023
Location sceneId's are now projects/<projectName>/<sceneName>.scene.json Select for sceneId is just <projectName>/<sceneName> Setting of state.scene in LocationDrawer.tsx was erroring since there were no matches, and then would prepend projects/ and append .scene.json to the sceneId if saved without touching the scene selector, which would then point the location to an invalid scene.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Location sceneId's are now projects//.scene.json Select for sceneId is just / Setting of state.scene in LocationDrawer.tsx was erroring since there were no matches, and then would prepend projects/ and append .scene.json to the sceneId if saved without touching the scene selector, which would then point the location to an invalid scene.
References
closes #insert number here
QA Steps