-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate method staker_info #11
Comments
Confirmed. I can classify this as a minor observation, non-security issue (10,000 CLO) because this does not pose a threat of losing funds for users. Please, provide your ETH/CLO address. However, it was stated that you should keep your reports private until the end of security audit EthereumCommonwealth/Roadmap#52 The reward will be evaluated after the end of the security audit. |
@Dexaran sorry about that (my public reports), but I mistakely decided such non-critical issues should be public to avoid duplicates. This contributions were the part of our public live stream smart contract audits, which help people to understand smart contracts logic better. So any reward is welcome, thank you :) Wallet: 0x083fc10cE7e97CaFBaE0fE332a9c4384c5f54E45 |
The issue with public reports is that we are running an official audit of this contract at the same time by our auditing team. We keep all audit reports and we may assign penalties if an auditor failed to report some issues. Now they can just copy&paste everything from here. However, it is not a great problem. Even more, there were no major issues yet.
Yeah, I've seen the link. |
Removed: - [Duplicate method staker_info](EthereumCommonwealth#11); - [Duplicate condition](EthereumCommonwealth#8). Updated function [stake_reward](EthereumCommonwealth#10).
@Dexaran thanks! |
This method:
Cold-staking/ColdStaking.sol
Line 226 in 863846e
Is already exist because of this line:
Cold-staking/ColdStaking.sol
Line 76 in 863846e
Public property auto-generates getter:
Auditing smart contracts in live stream: https://www.youtube.com/watch?v=efZY3_COaiE
Your CryptoManiacs :)
The text was updated successfully, but these errors were encountered: