Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate condition #8

Closed
k06a opened this issue Oct 11, 2018 · 3 comments
Closed

Duplicate condition #8

k06a opened this issue Oct 11, 2018 · 3 comments
Labels
confirmed

Comments

@k06a
Copy link

k06a commented Oct 11, 2018 •
edited
Loading

Remove this condition:

Cold-staking/ColdStaking.sol

Line 175 in 863846e

if (Timestamp >= staker[msg.sender].time + round_interval)

Because of exactly the same condition a few lines ago:

Cold-staking/ColdStaking.sol

Line 171 in 863846e

require(Timestamp >= staker[msg.sender].time + round_interval); //reject withdrawal before complete round.

Auditing smart contracts in live stream: https://www.youtube.com/watch?v=efZY3_COaiE

Your CryptoManiacs :)
@Dexaran
Copy link
Member

Dexaran commented Oct 12, 2018 •
edited
Loading

Confirmed.

Code improvements, non-security issues and other flaw reports (10,000 CLO)

yuriy77k added a commit to yuriy77k/Cold-staking that referenced this issue Oct 12, 2018
@yuriy77k
minor fixing
244ed1d 
Removed:
- [Duplicate method staker_info](EthereumCommonwealth#11);
- [Duplicate condition](EthereumCommonwealth#8).

Updated function [stake_reward](EthereumCommonwealth#10).
@yuriy77k yuriy77k mentioned this issue Oct 12, 2018
Merged
@Dexaran
Copy link
Member

Dexaran commented Oct 28, 2018

Paid https://explorer2.callisto.network/tx/0x846d54174d22cba91c42f0e401b6d54f4b79c568cb887985108cb12a4908a078

@k06a
Copy link
Author

k06a commented Oct 28, 2018

@Dexaran thanks!

@k06a k06a closed this as completed Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@k06a @Dexaran