New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate condition #8

Closed
k06a opened this Issue Oct 11, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@k06a
Copy link

k06a commented Oct 11, 2018

Remove this condition:

if (Timestamp >= staker[msg.sender].time + round_interval)

Because of exactly the same condition a few lines ago:

require(Timestamp >= staker[msg.sender].time + round_interval); //reject withdrawal before complete round.

Auditing smart contracts in live stream: https://www.youtube.com/watch?v=efZY3_COaiE

Your CryptoManiacs :)

@Dexaran

This comment has been minimized.

Copy link
Member

Dexaran commented Oct 12, 2018

Confirmed.

Code improvements, non-security issues and other flaw reports (10,000 CLO)

@Dexaran Dexaran added the confirmed label Oct 12, 2018

yuriy77k added a commit to yuriy77k/Cold-staking that referenced this issue Oct 12, 2018

minor fixing
Removed:
- [Duplicate method staker_info](EthereumCommonwealth#11);
- [Duplicate condition](EthereumCommonwealth#8).

Updated function [stake_reward](EthereumCommonwealth#10).
@k06a

This comment has been minimized.

Copy link

k06a commented Oct 28, 2018

@Dexaran thanks!

@k06a k06a closed this Oct 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment