Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groundhog Proposal #6

Merged
merged 7 commits into from
Jul 12, 2018
Merged

Groundhog Proposal #6

merged 7 commits into from
Jul 12, 2018

Conversation

androolloyd
Copy link
Contributor

No description provided.

owocki
owocki reviewed Jul 12, 2018
View reviewed changes
standards/groundhog_standard.md
* @param bytes _subscriptionHash is the identifier of the customer's subscription with its relevant details.
* @return (
address destination,
address recipient,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add token_address and token_decimals as return items to this array?

owocki
owocki reviewed Jul 12, 2018
View reviewed changes
standards/groundhog_standard.md

/** @dev returns the value of the subscription
* @param bytes _subscriptionHash is the identifier of the customer's subscription with its relevant details.
* @return value is the value that has been subscribed for the requested subscription
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in what denomination?

owocki
owocki reviewed Jul 12, 2018
View reviewed changes
standards/groundhog_standard.md
```SOLIDITY

/** @dev handles the incoming data to define subscription rules
* @param address _destination
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that _data, and _meta needs more specification to say what it is. what should be stored here?

for expires and _interval, are these unix timestamps and ints that represent seconds, respectively?

@owocki
Copy link
Contributor

owocki commented Jul 12, 2018 •
edited
Loading

just read this end to end. looking good.

my high level thoughts:

  1. we need to support erc20 tokens out of the gate
  2. we should specify Events which belong in the standard. I suggest SubscriptionCreated, SubscriptionPaused, SubscriptionExecuted, SubscriptionCanceled

Low level thoughts?

  1. Is it worth specifying function modifiers, like onlyBiller or onlyFunder on the various write events?
  2. Is it worth adding read functions like getSubscriptionsbyAddress() which allow a user to easily lookup their _subscriptionHashes via their address?

@owocki owocki merged commit def0cb3 into EthereumOpenSubscriptions:master Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owocki owocki owocki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@androolloyd @owocki