Unifies logging into stdout, fixes empty unison.log #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, logging doesn't work as expected:
```
ls -ls /tmp/
total 531728
0 -rw------- 1 root root 0 Apr 25 02:30 monit-stdout---supervisor-jE8Kdx.log
0 srwx------ 1 root root 0 Apr 25 02:30 supervisor.sock
12 -rw-r--r-- 1 root root 10685 Apr 25 12:23 supervisord.log
4 -rw-r--r-- 1 root root 2 Apr 25 02:30 supervisord.pid
19628 -rw-r--r-- 1 root root 20097343 Apr 25 12:23 unison-stdout---supervisor-JHhBXk.log
51204 -rw-r--r-- 1 root root 52428861 Apr 25 03:21 unison-stdout---supervisor-JHhBXk.log.1
51212 -rw-r--r-- 1 root root 52437692 Apr 25 03:15 unison-stdout---supervisor-JHhBXk.log.10
51204 -rw-r--r-- 1 root root 52432255 Apr 25 03:20 unison-stdout---supervisor-JHhBXk.log.2
51204 -rw-r--r-- 1 root root 52430230 Apr 25 03:20 unison-stdout---supervisor-JHhBXk.log.3
51204 -rw-r--r-- 1 root root 52429104 Apr 25 03:18 unison-stdout---supervisor-JHhBXk.log.4
51216 -rw-r--r-- 1 root root 52442028 Apr 25 03:17 unison-stdout---supervisor-JHhBXk.log.5
51212 -rw-r--r-- 1 root root 52438895 Apr 25 03:17 unison-stdout---supervisor-JHhBXk.log.6
51208 -rw-r--r-- 1 root root 52433297 Apr 25 03:17 unison-stdout---supervisor-JHhBXk.log.7
51216 -rw-r--r-- 1 root root 52443988 Apr 25 03:16 unison-stdout---supervisor-JHhBXk.log.8
51204 -rw-r--r-- 1 root root 52430102 Apr 25 03:15 unison-stdout---supervisor-JHhBXk.log.9
0 -rw-rw-rw- 1 root root 0 Oct 24 2019 unison.log
```
As can be seen above, unison.log is empty. This change makes it so all
logs are available via `docker logs` command instead, where it works
reliably
|
That sounds very reasonable to me, not sure whey we did not use the docker stdout /stderr pipe yet |
|
Thank you for the contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, logging doesn't work as expected:
As can be seen above, unison.log is empty. This change makes it so all logs are available via
docker logscommand instead, where it works reliably.Used https://stackoverflow.com/a/39127732/524965