Fixes invalid page slug when on a localhost with port or different protocol #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 6, 2020 18:45
…ed doubleqoutes to single qoutes + removed unused variables
schuhwerk
pushed a commit
to schuhwerk/vuejs-mapbox-wordpress-theme-starter
that referenced
this pull request
Nov 13, 2023
…otocol (EvanAgee#102) * removed lodash as dependency, instead using native ecma/es6 + converted doubleqoutes to single qoutes + removed unused variables * removed commented out lines * removed more commented out code * proper slug creation (takes port number and protocol into account)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where an invalid slug would be generated if you were on say localhost:3080 or with a different protocol.