Fix: Participation vs. partecipation #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| * @deprecated | ||
| * | ||
| * @param string $owner | ||
| * @param string $repo | ||
| * @return string | ||
| */ | ||
| public function partecipation($owner, $repo) |
There was a problem hiding this comment.
Not sure if this is needed anymore, but leaving it here for BC.
localheinz
force-pushed
the
fix/participation
branch
from
b2dbfd8
to
c65eddb
Compare
|
I highly doubt anyone was using the broken method name, so we don't need to worry about the BC break here. |
|
Ok thanks for this feedback! 👍 |
|
@localheinz rebase please :) Thanks! |
localheinz
force-pushed
the
fix/participation
branch
2 times, most recently
from
c5cbc9f
to
c1a9f44
Compare
localheinz
force-pushed
the
fix/participation
branch
from
278bab0
to
dc9d973
Compare
|
There you are! |
gianarb
pushed a commit
that referenced
this pull request
Mar 6, 2015
Fix: Participation vs. partecipation
|
Thanks @localheinz !!! |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
it should be
See https://developer.github.com/v3/repos/statistics/#participation.