Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Run php-cs-fixer on Travis #32

Merged
merged 6 commits into from
Mar 2, 2015

Conversation

localheinz
Copy link
Contributor

This PR

  • removes squizlabs/php_codesniffer
  • adds fabpot/php-cs-fixer
  • adds a configuration for php-cs-fixer
  • performs a dry-run of php-cs-fixer on Travis
  • performs an actual run of php-cs-fixer

Replaces #20.

'remove_lines_between_uses',
'return',
'single_array_no_trailing_comma',
// 'short_array_syntax',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.86% when pulling 841e861 on localheinz:feature/php-cs-fixer into 077b1e2 on EvanDotPro:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.86% when pulling 841e861 on localheinz:feature/php-cs-fixer into 077b1e2 on EvanDotPro:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.86% when pulling 7edf48f on localheinz:feature/php-cs-fixer into 077b1e2 on EvanDotPro:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.86% when pulling 7848260 on localheinz:feature/php-cs-fixer into 077b1e2 on EvanDotPro:master.

@localheinz localheinz force-pushed the feature/php-cs-fixer branch 2 times, most recently from f50727d to 2148937 Compare February 7, 2015 18:31
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.86% when pulling f50727d on localheinz:feature/php-cs-fixer into 077b1e2 on EvanDotPro:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.86% when pulling 2148937 on localheinz:feature/php-cs-fixer into 077b1e2 on EvanDotPro:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.86% when pulling 2148937 on localheinz:feature/php-cs-fixer into 077b1e2 on EvanDotPro:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.86% when pulling 2148937 on localheinz:feature/php-cs-fixer into 077b1e2 on EvanDotPro:master.

@gianarb
Copy link
Collaborator

gianarb commented Feb 26, 2015

@localheinz in this moment this is very difficult to merge! 😰
In my opinion the cs_fix into the travis build is a very good stuff because it raises the code quality..
But I can try to add this feature in another time :)

@localheinz
Copy link
Contributor Author

@gianarb

How about this, now? I rebased and ran the fixer again.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.02% when pulling 3dde94c on localheinz:feature/php-cs-fixer into 4e5c75d on EvanDotPro:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.02% when pulling 3dde94c on localheinz:feature/php-cs-fixer into 4e5c75d on EvanDotPro:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.02% when pulling 3dde94c on localheinz:feature/php-cs-fixer into 4e5c75d on EvanDotPro:master.

@gianarb
Copy link
Collaborator

gianarb commented Mar 1, 2015

Thanks @localheinz

gianarb pushed a commit that referenced this pull request Mar 2, 2015
Enhancement: Run php-cs-fixer on Travis
@gianarb gianarb merged commit 8ac20f1 into EvanDotPro:master Mar 2, 2015
@GrahamCampbell
Copy link

Why not use https://styleci.io? It separates this from the actual tests you can see which bit failed straight away.

@localheinz localheinz deleted the feature/php-cs-fixer branch March 12, 2015 22:03
@gianarb
Copy link
Collaborator

gianarb commented Mar 13, 2015

Hi! @GrahamCampbell this is the evolution of FabBot?! :)
In my opinion this is a good idea! The CsFix is not a total failure for me.. But a simple status to underline it is the solution!

@GrahamCampbell
Copy link

this is the evolution of FabBot?! :)

This is totally separate from fabot. Fabot is closed source, so I wrote StyleCI and made it open source. :)

@GrahamCampbell
Copy link

And am providing a free hosted service. :)

@gianarb
Copy link
Collaborator

gianarb commented Mar 13, 2015

Beautiful! :) Thanks for your work!

@localheinz
Copy link
Contributor Author

@GrahamCampbell

TANSTAAFL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants