Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back arrow to favorites screen #411

Open
johnjohndoe opened this issue Oct 25, 2021 · 3 comments
Open

Add back arrow to favorites screen #411

johnjohndoe opened this issue Oct 25, 2021 · 3 comments
Assignees
@Chase22
Labels
Favorites The favorites screen, starring a session Help wanted You are invited to help. Please annouce it as a comment on the issue. UX User experience, accessibility, screen readers, touch feedback, ...

Comments

@johnjohndoe
Copy link
Member

There's no "up affordance" in the "Favorites" screen.

Originally posted by @cketti in #404 (review)
@johnjohndoe johnjohndoe added UX User experience, accessibility, screen readers, touch feedback, ... Favorites The favorites screen, starring a session labels Oct 25, 2021
@johnjohndoe johnjohndoe added the Help wanted You are invited to help. Please annouce it as a comment on the issue. label Dec 13, 2021
@Chase22 Chase22 mentioned this issue May 21, 2022
Closed
@Chase22
Copy link
Contributor

Chase22 commented May 22, 2022

I'd like to work on this

Given that we are working with the SupportToolbars already this should be as simple as calling supportToolbar.displayHomeAsUpEnabled = true will just need some testing to make sure there aren't any weird side effects when navigating, but using the device back button already works fine

@johnjohndoe
Copy link
Member Author

Nice. Go ahead.

Hint: Please also check that everything works with tablets. There is a different architecture (activities, fragments, layouts) in place.

@johnjohndoe
Copy link
Member Author

@Chase22 Did you have time to work on this task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chase22 Chase22

Labels
Favorites The favorites screen, starring a session Help wanted You are invited to help. Please annouce it as a comment on the issue. UX User experience, accessibility, screen readers, touch feedback, ...
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnjohndoe @Chase22