This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
all: scala 2.13 support + sbt syntax #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t3hnar WDYT? |
ahjohannessen
force-pushed
the
wip-scala213
branch
2 times, most recently
from
dca410c
to
f8650bb
Compare
t3hnar
suggested changes
Mar 22, 2019
- add scala 2.13 support. - fix value-discard issues in `SourceStageLogic`, `Client` and `ConnectionActor`. - fix tests in `ProjectionsClientITest` wrt. `should beSome(X)` and `X` is a case object to be `shouldEqual Some(X)` as Scala 2.13 fails with a `type mismatch` error. - add `ScalaCompat` object in unmanaged sources in core project in order to be able to cross compile. - change `TestConnection` to use `ScalaCompat` in order to get Scala 2.12 and 2.13 working with minimal changes, `LazyList` replaces `Stream`. - fix shadow warnings and unused variables in `ConnectionActorSpec` and `ProjectionsClientITest`. - change `OneToMany` to use `Iterable` and `IterableOnce` and use `import eventstore.ScalaCompat._` in order to have cross builds working. - change build.sbt and version.sbt to use recommended syntax for scopes. - bump sbt-scoverage to 1.6.0-M5 in order to get 2.13 support.
ahjohannessen
force-pushed
the
wip-scala213
branch
from
f8650bb
to
3a4ab3d
Compare
t3hnar
approved these changes
Mar 22, 2019
|
@t3hnar feedback applied - I'll do a follow up PR with |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add scala 2.13 support.
fix value-discard issues in
SourceStageLogic,Clientand
ConnectionActor.fix tests in
ProjectionsClientITestwrt.should beSome(X)and
Xis a case object to beshouldEqual Some(X)asScala 2.13 fails with a
type mismatcherror.add
ScalaCompatobject in unmanaged sources incore project in order to be able to cross compile.
change
TestConnectionto useScalaCompatin order to getScala 2.12 and 2.13 working with minimal changes,
LazyListreplaces
Stream.fix shadow warnings and unused variables in
ConnectionActorSpecand
ProjectionsClientITest.change
OneToManyto useIterableandIterableOnceanduse
import eventstore.ScalaCompat._in order to have crossbuilds working.
change build.sbt and version.sbt to use recommended syntax
for scopes.
bump sbt-scoverage to 1.6.0-M5 in order to get 2.13 support.